From owner-freebsd-ports@FreeBSD.ORG  Sun Sep  8 06:43:48 2013
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 8E8FB77A
 for <freebsd-ports@freebsd.org>; Sun,  8 Sep 2013 06:43:48 +0000 (UTC)
 (envelope-from bsd-src@helfman.org)
Received: from mail-pd0-f179.google.com (mail-pd0-f179.google.com
 [209.85.192.179])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 66C4F2CC6
 for <freebsd-ports@freebsd.org>; Sun,  8 Sep 2013 06:43:48 +0000 (UTC)
Received: by mail-pd0-f179.google.com with SMTP id v10so4902906pde.38
 for <freebsd-ports@freebsd.org>; Sat, 07 Sep 2013 23:43:42 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:sender:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=ONmWKr2sABZZEtBN7oq9m1rsv3J7wnpmY832/PBab4Y=;
 b=dJ9kdleazhDn30I2nKLBDhY1cYJC4laSEOu/qbBOiIH2XWl26MgNwk8E8ZzUfXNgOb
 Jr+Js4HDsk92oHxDK1HDuBWIWFyQ34x9BkzrogtEQ1m6WHtPM7xNa6Dt5AEI9ez0wZSQ
 nAPuVYBTQgVrmtDwolZtykz0oGLRn7IIozbPQcRTQfrNYLy5k0PNI+4yszDAnvPm7LRe
 S1lYiVebKA9oAAgg+Ii2v8EI08+iFdNaQxmvD8aeJhZ8bqz4lsFaSOKg5TUeLscgvGRk
 u72DibXxRxZXYNU6enWJI8YKAFHBFOQnBMg7FEGaPKU/ITfwkoU8ZSyMbe4CmiCqKJDV
 9cRQ==
X-Gm-Message-State: ALoCoQktNctI9NkjpBWq+O84lGu1orRNoIt2hZzVcEvxKOCkR1AxHq9QEwcTStUJllaoUWGd3ccM
MIME-Version: 1.0
X-Received: by 10.68.169.161 with SMTP id af1mr12285326pbc.22.1378622622575;
 Sat, 07 Sep 2013 23:43:42 -0700 (PDT)
Sender: bsd-src@helfman.org
Received: by 10.70.100.165 with HTTP; Sat, 7 Sep 2013 23:43:42 -0700 (PDT)
In-Reply-To: <l0g6jl$jf0$1@lorvorc.mips.inka.de>
References: <l0g6jl$jf0$1@lorvorc.mips.inka.de>
Date: Sat, 7 Sep 2013 23:43:42 -0700
X-Google-Sender-Auth: 5zR5Uc5pBo66t9_edhCrUYTpQTg
Message-ID: <CAMuy=+iqFsQst-tEYJmNmyih3eXfEGLa2XR3=u2ada=pKDMq4g@mail.gmail.com>
Subject: Re: bsd.port.pre.mk vs bsd.port.options.mk
From: Jason Helfman <jgh@FreeBSD.org>
To: Christian Weisgerber <naddy@mips.inka.de>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.14
Cc: FreeBSD Ports List <freebsd-ports@freebsd.org>
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Sep 2013 06:43:48 -0000

On Sat, Sep 7, 2013 at 2:42 PM, Christian Weisgerber <naddy@mips.inka.de>wrote:

> I have port that does something like
>
>     .include <bsd.port.pre.mk>
>
>     .if ${ARCH} == ...
>     ...
>     .endif
>
>     .include <bsd.port.post.mk>
>
> A while back somebody submitted a PR asking me to replace bsd.port.pre.mk
> with bsd.port.options.mk, because it also makes ARCH available and
> is far less expensive.
>
> Now, a priori it is not clear to me that including options.mk is
> actually cheaper than pre.mk.  And it seems odd to include options.mk
> but then not use any part of the options framework.  The Porter's
> Handbook explicitly mentions ARCH as one of the variables provided
> by pre.mk.
>
> What's the preferred way to handle this?
>
> --
> Christian "naddy" Weisgerber                          naddy@mips.inka.de
>
>
It is preferred to evaluate ARCH with bsd.port.options.mk.

-jgh



-- 
Jason Helfman          | FreeBSD Committer
jgh@FreeBSD.org     | http://people.freebsd.org/~jgh  | The Power to Serve