From owner-svn-soc-all@freebsd.org  Mon Oct 26 07:03:44 2015
Return-Path: <owner-svn-soc-all@freebsd.org>
Delivered-To: svn-soc-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DD0F6A1CDA9
 for <svn-soc-all@mailman.ysv.freebsd.org>;
 Mon, 26 Oct 2015 07:03:44 +0000 (UTC) (envelope-from def@FreeBSD.org)
Received: from socsvn.freebsd.org (socsvn.freebsd.org
 [IPv6:2001:1900:2254:206a::50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id CB27911FC
 for <svn-soc-all@FreeBSD.org>; Mon, 26 Oct 2015 07:03:44 +0000 (UTC)
 (envelope-from def@FreeBSD.org)
Received: from socsvn.freebsd.org ([127.0.1.124])
 by socsvn.freebsd.org (8.15.2/8.15.2) with ESMTP id t9Q73i0U086033
 for <svn-soc-all@FreeBSD.org>; Mon, 26 Oct 2015 07:03:44 GMT
 (envelope-from def@FreeBSD.org)
Received: (from www@localhost)
 by socsvn.freebsd.org (8.15.2/8.15.2/Submit) id t9Q73iEF086031
 for svn-soc-all@FreeBSD.org; Mon, 26 Oct 2015 07:03:44 GMT
 (envelope-from def@FreeBSD.org)
Date: Mon, 26 Oct 2015 07:03:44 GMT
Message-Id: <201510260703.t9Q73iEF086031@socsvn.freebsd.org>
X-Authentication-Warning: socsvn.freebsd.org: www set sender to
 def@FreeBSD.org using -f
From: def@FreeBSD.org
To: svn-soc-all@FreeBSD.org
Subject: socsvn commit: r293061 - soc2013/def/crashdump-head/sbin/savecore
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-soc-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the entire Summer of Code repository
 <svn-soc-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-soc-all>,
 <mailto:svn-soc-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-soc-all/>
List-Post: <mailto:svn-soc-all@freebsd.org>
List-Help: <mailto:svn-soc-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-soc-all>,
 <mailto:svn-soc-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Oct 2015 07:03:45 -0000

Author: def
Date: Mon Oct 26 07:03:43 2015
New Revision: 293061
URL: http://svnweb.FreeBSD.org/socsvn/?view=rev&rev=293061

Log:
  Close all descriptors due to a fail.

Modified:
  soc2013/def/crashdump-head/sbin/savecore/savecore.c

Modified: soc2013/def/crashdump-head/sbin/savecore/savecore.c
==============================================================================
--- soc2013/def/crashdump-head/sbin/savecore/savecore.c	Mon Oct 26 04:11:33 2015	(r293060)
+++ soc2013/def/crashdump-head/sbin/savecore/savecore.c	Mon Oct 26 07:03:43 2015	(r293061)
@@ -712,7 +712,7 @@
 		if (dumpkey == NULL) {
 			syslog(LOG_ERR, "Unable to allocate kernel dump key.");
 			nerr++;
-			goto closefd;
+			goto closeall;
 		}
 
 		error = read(fd, dumpkey, dumpkeysize);