From owner-freebsd-rc@FreeBSD.ORG Thu Sep 6 23:36:47 2012 Return-Path: Delivered-To: rc@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53]) by hub.freebsd.org (Postfix) with ESMTP id B0FF11065674; Thu, 6 Sep 2012 23:36:47 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from [127.0.0.1] (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 6376114D91A; Thu, 6 Sep 2012 23:36:47 +0000 (UTC) Message-ID: <5049338F.5060702@FreeBSD.org> Date: Thu, 06 Sep 2012 16:36:47 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: Glen Barber References: <20120906195706.GD1332@glenbarber.us> <50491DB2.1020702@FreeBSD.org> <20120906221036.GF1332@glenbarber.us> In-Reply-To: <20120906221036.GF1332@glenbarber.us> X-Enigmail-Version: 1.4.3 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: rc@FreeBSD.org Subject: Re: [PATCH] Allow use of program path overrides X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Sep 2012 23:36:47 -0000 On 9/6/2012 3:10 PM, Glen Barber wrote: > On Thu, Sep 06, 2012 at 03:03:30PM -0700, Doug Barton wrote: >> On 9/6/2012 12:57 PM, Glen Barber wrote: >>> Hi, >>> >>> Many rc(8) scripts have corresponding 'foo_program="/path/to/foo"' >>> entries in etc/defaults/rc.conf . >> >> These are usually only added for things that might get overridden by >> something from ports. >> > > I can think of valid reasons one might want to do this otherwise. Me too, but I would prefer not to clutter defaults/rc.conf without good reason. The fact that no variable is in there doesn't mean that users can't still do it if they need to. >>> However, some are missing the functionality to override $command >>> correctly. >> >> rc.subr should already do that. Have you tested it? >> > > Yes. See the previous thread on -rc@ . David never mentioned that he actually tested it, and just confirmed that he didn't. Did you actually test it? Doug -- I am only one, but I am one. I cannot do everything, but I can do something. And I will not let what I cannot do interfere with what I can do. -- Edward Everett Hale, (1822 - 1909)