From owner-freebsd-current@FreeBSD.ORG  Tue Jan 27 16:19:53 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 84E9010656BC
	for <freebsd-current@FreeBSD.org>; Tue, 27 Jan 2009 16:19:53 +0000 (UTC)
	(envelope-from jh@saunalahti.fi)
Received: from emh01.mail.saunalahti.fi (emh01.mail.saunalahti.fi
	[62.142.5.107]) by mx1.freebsd.org (Postfix) with ESMTP id 3F0268FC18
	for <freebsd-current@FreeBSD.org>; Tue, 27 Jan 2009 16:19:53 +0000 (UTC)
	(envelope-from jh@saunalahti.fi)
Received: from saunalahti-vams (vs3-12.mail.saunalahti.fi [62.142.5.96])
	by emh01-2.mail.saunalahti.fi (Postfix) with SMTP id 1B3A11A8DF
	for <freebsd-current@FreeBSD.org>; Tue, 27 Jan 2009 18:19:52 +0200 (EET)
Received: from emh07.mail.saunalahti.fi ([62.142.5.117])
	by vs3-12.mail.saunalahti.fi ([62.142.5.96])
	with SMTP (gateway) id A02C10CED9E; Tue, 27 Jan 2009 18:19:51 +0200
Received: from a91-153-125-115.elisa-laajakaista.fi
	(a91-153-125-115.elisa-laajakaista.fi [91.153.125.115])
	by emh07.mail.saunalahti.fi (Postfix) with SMTP id 038DD1C6394
	for <freebsd-current@FreeBSD.org>; Tue, 27 Jan 2009 18:19:50 +0200 (EET)
Date: Tue, 27 Jan 2009 18:19:50 +0200
From: Jaakko Heinonen <jh@saunalahti.fi>
To: freebsd-current@FreeBSD.org
Message-ID: <20090127161950.GA3504@a91-153-125-115.elisa-laajakaista.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.18 (2008-05-17)
X-Antivirus: VAMS
Cc: 
Subject: [patch] nfs attribute cache mount options broken on CURRENT
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Jan 2009 16:19:55 -0000


Hi,

nfs mount options acregmin, acregmax, acdirmin and acdirmax are broken
on CURRENT (unless you use an old mount_nfs binary which passes options
differently).

The problem is that nfs_mount() (in sys/nfsclient/nfs_vfsops.c) doesn't
set flags for those options when they are passed as string options. Also
the new code doesn't allow setting the options to 0 which is needed to
disable the attribute cache.

This patch should fix the problem:

http://www.saunalahti.fi/~jh3/patches/nfs-ac-mountopts.diff

-- 
Jaakko