From owner-freebsd-hackers  Tue Jul 17  1:25:38 2001
Delivered-To: freebsd-hackers@freebsd.org
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by hub.freebsd.org (Postfix) with ESMTP id 4B62637B415
	for <hackers@FreeBSD.ORG>; Tue, 17 Jul 2001 01:25:32 -0700 (PDT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter (localhost [127.0.0.1])
	by critter.freebsd.dk (8.11.3/8.11.3) with ESMTP id f6H8PBn94592;
	Tue, 17 Jul 2001 10:25:11 +0200 (CEST)
	(envelope-from phk@critter.freebsd.dk)
To: Harti Brandt <brandt@fokus.gmd.de>
Cc: hackers@FreeBSD.ORG
Subject: Re: Really simple patch... 
In-Reply-To: Your message of "Tue, 17 Jul 2001 10:22:11 +0200."
             <20010717101638.V11504-100000@beagle.fokus.gmd.de> 
Date: Tue, 17 Jul 2001 10:25:11 +0200
Message-ID: <94590.995358311@critter>
From: Poul-Henning Kamp <phk@critter.freebsd.dk>
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-hackers.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-hackers>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-hackers>
X-Loop: FreeBSD.ORG


fixed.

In message <20010717101638.V11504-100000@beagle.fokus.gmd.de>, Harti Brandt writes:
>
>Could please somebody make this little, trivial and obviuos patch, I
>requested it a while ago, or should I make a PR for it??
>
>Hi,
>
>()s are missing around the macro argument in cv_waitq_empty. The call
>
>        if(!(cv_waitq_empty(&sc->foo_cv)))
>                ...
>
>will otherwise fail to compile.
>
>harti
>
>Index: condvar.h
>===================================================================
>RCS file: /usr/ncvs/src/sys/sys/condvar.h,v
>retrieving revision 1.2
>diff -r1.2 condvar.h
>66c66
>< #define       cv_waitq_empty(cvp)     (TAILQ_EMPTY(&cvp->cv_waitq))
>---
>> #define       cv_waitq_empty(cvp)     (TAILQ_EMPTY(&(cvp)->cv_waitq))
>
>
>-- 
>harti brandt, http://www.fokus.gmd.de/research/cc/cats/employees/hartmut.brandt/private
>              brandt@fokus.gmd.de, harti@begemot.org
>
>
>To Unsubscribe: send mail to majordomo@FreeBSD.org
>with "unsubscribe freebsd-hackers" in the body of the message
>

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message