From owner-svn-src-all@FreeBSD.ORG Sat Jul 13 14:18:08 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id CFC5995E; Sat, 13 Jul 2013 14:18:08 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-la0-x22e.google.com (mail-la0-x22e.google.com [IPv6:2a00:1450:4010:c03::22e]) by mx1.freebsd.org (Postfix) with ESMTP id 8B92F11D4; Sat, 13 Jul 2013 14:18:07 +0000 (UTC) Received: by mail-la0-f46.google.com with SMTP id eg20so8488246lab.19 for ; Sat, 13 Jul 2013 07:18:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=MEs4mvQ2tKm1fTcY3YWj01wmvzRr1CPLU5xFXXESWX8=; b=zMHtJbuft0G86PSzU/L3ApiTGmBPdA5FSq2kPkQiR4gI3Fz8Ji5vD01x8ZmPevM4mR fVOlD4NkuARJHUFtNleoCcGGQZV15xcgHL6+FvuHuVHaSZsQueJEs46zQuQF9lz6f7/W z6x1syM3QfLlse8tRf0uz4/ADFgkM8n2quGHIm0brgjq6+ho7Q81me0ZD0iqjpT9NVWk c8i/ZXsGrUWAtbNg/1U76lkSezRijbRhIw1+YeGh6w1hSU33rC8+TPYbDdH412ZsNi9G +SKW+6cOA3YpBEvzba1qhwMeyvn6qI76r7W6lBvbB0b95i06/gjQrK+gy8vPlfonRkZH k+kg== X-Received: by 10.112.135.99 with SMTP id pr3mr20887310lbb.23.1373725086422; Sat, 13 Jul 2013 07:18:06 -0700 (PDT) Received: from localhost ([178.150.115.244]) by mx.google.com with ESMTPSA id n3sm16066354lag.9.2013.07.13.07.18.04 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 13 Jul 2013 07:18:05 -0700 (PDT) Sender: Mikolaj Golub Date: Sat, 13 Jul 2013 17:18:03 +0300 From: Mikolaj Golub To: Craig Rodrigues Subject: Re: svn commit: r253255 - head/sys/netgraph/bluetooth/drivers/ubt Message-ID: <20130713141802.GG2757@gmail.com> References: <201307120803.r6C83ACp016523@svn.freebsd.org> <20130712202710.GB2757@gmail.com> <20130713073118.GC2757@gmail.com> <20130713111825.GE2757@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130713111825.GE2757@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Adrian Chadd , src-committers@freebsd.org, Marko Zec X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jul 2013 14:18:08 -0000 On Sat, Jul 13, 2013 at 02:18:26PM +0300, Mikolaj Golub wrote: > I wonder if it fails on current too? It looks this code is not there > any more. I will try. Yes. It crashes on current too. In pfattach(). Also, loading ipfw and ipfw_nat causes panics in ipfw_init() and ipfw_nat_init(). Although this can be easily bandaged with CURVNET_SET(vnet0), it rather reveals problems with these modules. E.g. currently in ipfw_nat_init() we lock virtualized layer3_chain in vnet0 context, I think, to restrict the access to ipfw_nat_*_ptr variables during modification. But the access is not protected from another vnets, which might already exist at the moment when ipfw_nat is loaded. -- Mikolaj Golub