Date: Sun, 26 Feb 2017 21:27:48 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Cy Schubert <Cy.Schubert@komquats.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314322 - head/lib/librss Message-ID: <404d743b-735b-0605-5ab5-ccb95ce24ad8@FreeBSD.org> In-Reply-To: <201702270151.v1R1pe1F003587@slippy.cwsent.com> References: <201702270151.v1R1pe1F003587@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello; On 2/26/2017 8:51 PM, Cy Schubert wrote: > In message <201702270010.v1R0A1wm074123@repo.freebsd.org>, "Pedro F. > Giffuni" w > rites: >> Author: pfg >> Date: Mon Feb 27 00:10:00 2017 >> New Revision: 314322 >> URL: https://svnweb.freebsd.org/changeset/base/314322 >> >> Log: >> librss: simplify some NULL checks. >> >> MFC after: 1 week >> >> Modified: >> head/lib/librss/librss.c >> >> Modified: head/lib/librss/librss.c >> ============================================================================= >> = >> --- head/lib/librss/librss.c Sun Feb 26 22:17:06 2017 (r314321) >> +++ head/lib/librss/librss.c Mon Feb 27 00:10:00 2017 (r314322) >> @@ -244,10 +244,10 @@ rss_config_get(void) >> return (rc); >> >> error: >> - if ((rc != NULL) && rc->rss_bucket_map) >> + if (rc != NULL) { >> free(rc->rss_bucket_map); > What happens if rc is not NULL and rc->rss_bucket_map is NULL? According the free(3): " If /ptr/ is *NULL*, no action occurs." Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?404d743b-735b-0605-5ab5-ccb95ce24ad8>