Date: Sat, 20 May 2017 10:43:55 -0400 From: Dan Langille <dan@langille.org> To: Joseph Mingrone <jrm@FreeBSD.org> Cc: Adam Weinberger <adamw@adamw.org>, Dan Langille <dvl@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r441282 - in head: . security security/acme.sh Message-ID: <1B06ABAD-CDC3-4A18-9BC5-95D3D97701E9@langille.org> In-Reply-To: <86d1b3lwx0.fsf@phe.ftfl.ca> References: <201705200227.v4K2RjjG055940@repo.freebsd.org> <989C2BB0-AC4E-4C76-AB15-9F616A6EF392@adamw.org> <86d1b3lwx0.fsf@phe.ftfl.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_4BCA18B1-4B08-4DF9-B25C-27B0357A0C78 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On May 20, 2017, at 5:06 AM, Joseph Mingrone <jrm@FreeBSD.org> wrote: >=20 > Adam Weinberger <adamw@adamw.org> writes: >=20 >>> On 19 May, 2017, at 20:27, Dan Langille <dvl@FreeBSD.org> wrote: >=20 >>> Author: dvl >>> Date: Sat May 20 02:27:45 2017 >>> New Revision: 441282 >>> URL: https://svnweb.freebsd.org/changeset/ports/441282 >=20 >>> Log: >>> A pure Unix shell script implementing ACME client protocol >=20 >>> Differential Revision: https://reviews.freebsd.org/D10308 >=20 >>> Added: >>> head/security/acme.sh/ >>> head/security/acme.sh/Makefile (contents, props changed) >>> head/security/acme.sh/distinfo (contents, props changed) >>> head/security/acme.sh/pkg-descr (contents, props changed) >>> Modified: >>> head/GIDs >>> head/UIDs >>> head/security/Makefile >=20 >=20 >>> +RUN_DEPENDS=3D curl:ftp/curl >>> + >>> +OPTIONS_DEFINE=3D CURL DOCS WGET >>> +OPTIONS_DEFAULT=3D CURL >>> +CURL_DESC=3D Add ftp/curl as a run-time dependency >>> +WGET_DESC=3D Add ftp/wget as a run-time dependency >>> + >>> +CURL_RUN_DEPENDS=3D curl:ftp/curl >>> +WGET_RUN_DEPENDS=3D wget:ftp/wget >=20 >> Hi Dan, >=20 >> You have curl as a mandatory and optional dependency, which = effectively makes curl mandatory. I think you want to use OPTIONS_SINGLE = or OPTIONS_MULTI here, to make it an actual choice between the two of = them. >=20 >> Also the descriptions are a bit strange. I mean, it does add them as = a dependency, but I think an end-user would be more concerned with what = curl or wget does for acme.sh, no? >=20 >> # Adam >=20 > Hi Adam, Dan, >=20 > The link below is a patch with proposed changes. >=20 > http://ftfl.ca/misc/acme.sh-2.6.9.diff >=20 > Changelog: > - Add OPTION_SINGLE for choosing one of cURL or Wget for HTTP(s) = queries > - Update CURL/WGET descriptions [1] > - Silence porlint warnings >=20 > [1] They do not say "Use cURL/Wget...", because acme.sh will, by > default, use cURL if both cURL and Wget are installed Patch committed. Thank you. -- Dan Langille - BSDCan / PGCon dan@langille.org --Apple-Mail=_4BCA18B1-4B08-4DF9-B25C-27B0357A0C78 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iQF8BAEBCgBmBQJZIFY2XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRDRUE3MDlFMjg3QjI3RkNCMjA0QzgxMDEy MTREM0Q1RDREQTc1RUQzAAoJECFNPV1Np17TD20H/0wOTGKJDKdB3sp+LF86OdpP A5NDrbpxxVKICcK9B8qbUukJRNSr4jzI9WiPQAwSa/IS+q6x1wdHyDIe6+HkBEV5 ntv6rUq0jScaqWRSiPEDSokUWfpiVZ16eO0yc6IRfIFlzjXi+9DJR37KHXLydcmI Kuj83qRV8d2a9BtxadU3IkPVGjAGOKwHe3FzoIUVaBEUEjqVVt49C+ai+33gEX8K PhKaH7cqHsA+IHodtsflyLVC2qA0IF2sPt4GPMjiM8h58cH4LhMmbPL3xu1KppOj CCJcUq40/aaP7pdbpbdbepMtKrmBVhUJhEpVX/mDMgvEfWJLgo6Z+WZ3ShABXNs= =efPA -----END PGP SIGNATURE----- --Apple-Mail=_4BCA18B1-4B08-4DF9-B25C-27B0357A0C78--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1B06ABAD-CDC3-4A18-9BC5-95D3D97701E9>