Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 9 Dec 2013 17:39:52 +0200
From:      Aleksandr Rybalko <ray@ddteam.net>
To:        Marius Strobl <marius@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r259102 - head/sys/sparc64/sparc64
Message-ID:  <20131209173952.d6e3d3fb0fb5c9e84bc41bfb@ddteam.net>
In-Reply-To: <201312081525.rB8FPJK0023252@svn.freebsd.org>
References:  <201312081525.rB8FPJK0023252@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 8 Dec 2013 15:25:19 +0000 (UTC)
Marius Strobl <marius@FreeBSD.org> wrote:

> Author: marius
> Date: Sun Dec  8 15:25:19 2013
> New Revision: 259102
> URL: http://svnweb.freebsd.org/changeset/base/259102
> 
> Log:
>   Restore a vital comment nuked in r259016.
> 
> Modified:
>   head/sys/sparc64/sparc64/machdep.c
> 
> Modified: head/sys/sparc64/sparc64/machdep.c
> ==============================================================================
> --- head/sys/sparc64/sparc64/machdep.c	Sun Dec  8 14:21:54 2013	(r259101)
> +++ head/sys/sparc64/sparc64/machdep.c	Sun Dec  8 15:25:19 2013	(r259102)
> @@ -553,6 +553,13 @@ sparc64_init(caddr_t mdp, u_long o1, u_l
>  	 * trigger a fatal reset error or worse things further down the road.
>  	 * XXX it should be possible to use this solely instead of writing
>  	 * %tba in cpu_setregs().  Doing so causes a hang however.
> +	 *
> +	 * NB: the low-level console drivers require a working DELAY() and
> +	 * some compiler optimizations may cause the curthread accesses of
> +	 * mutex(9) to be factored out even if the latter aren't actually
> +	 * called.  Both of these require PCPU_REG to be set.  However, we
> +	 * can't set PCPU_REG without also taking over the trap table or the
> +	 * firmware will overwrite it.
>  	 */
>  	sun4u_set_traptable(tl0_base);
>  

Oh, I'm sorry.
It was old fix. Seems it here since 2009.

Thanks.

WBW
-- 
Aleksandr Rybalko <ray@ddteam.net>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131209173952.d6e3d3fb0fb5c9e84bc41bfb>