Date: Thu, 9 Jul 2009 19:30:46 +0200 From: Jilles Tjoelker <jilles@stack.nl> To: Edward Tomasz Napierala <trasz@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r195458 - in head: include lib/libc/sys sys/bsm sys/compat/freebsd32 sys/compat/svr4 sys/i386/ibcs2 sys/kern sys/sys Message-ID: <20090709173046.GA48155@stack.nl> In-Reply-To: <200907081523.n68FNIpi055036@svn.freebsd.org> References: <200907081523.n68FNIpi055036@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 08, 2009 at 03:23:18PM +0000, Edward Tomasz Napierala wrote: > Author: trasz > Date: Wed Jul 8 15:23:18 2009 > New Revision: 195458 > URL: http://svn.freebsd.org/changeset/base/195458 > Log: > There is an optimization in chmod(1), that makes it not to call chmod(2) > if the new file mode is the same as it was before; however, this > optimization must be disabled for filesystems that support NFSv4 ACLs. > Chmod uses pathconf(2) to determine whether this is the case - however, > pathconf(2) always follows symbolic links, while the 'chmod -h' doesn't. > This change adds lpathconf(3) to make it possible to solve that problem > in a clean way. I think pathconfat() would be nicer than adding a function that will not appear in standards and lacks a useful feature. Compare futimens() and utimensat() in the 2008 POSIX spec, and notice that there is no such thing as lutimes() in POSIX (it can be done with utimensat()). Another consideration is that lpathconf/pathconfat may be considered "new work". The problem I brought up can also be fixed by never using the optimization for symlinks. -- Jilles Tjoelker
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090709173046.GA48155>