Date: Thu, 28 Aug 2014 22:17:55 +0800 From: Chenguang Li <horus.li@gmail.com> To: Peter Pentchev <roam@ringlet.net> Cc: freebsd-hackers@freebsd.org, Vitaly Magerya <vmagerya@gmail.com> Subject: Re: On changing rand(3) to random(3) in awk(1) Message-ID: <B6FE2E90-A51B-4ABF-97E2-29881215F95F@gmail.com> In-Reply-To: <E02AE8AA-0974-42C6-AC83-C257DAFE329A@gmail.com> References: <F70B9462-0898-47EF-AF83-47509F21F84E@gmail.com> <53FEFBB8.5040305@gmail.com> <20140828131526.GA2385@straylight.m.ringlet.net> <5C40F611-22EB-49E4-8925-37922E771C0F@gmail.com> <20140828133846.GB2385@straylight.m.ringlet.net> <E02AE8AA-0974-42C6-AC83-C257DAFE329A@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Chenguang Li <horus.li@gmail.com> wrote: > Peter Pentchev <roam@ringlet.net> wrote: > >>> ... ... >>> [omitted] >> >> Right, but you've hard-coded RANDOM_MAX to 2^32-1. I don't think this >> is correct; I do believe that you should use LONG_MAX for this value. >> Of course, #define RANDOM_MAX LONG_MAX could be fine for this purpose >> here, but the point is to use LONG_MAX instead of 2^32-1. > > I got your point, updated again. :) Wait a minute, isn't LONG_MAX architecture-dependent? It's 9223372036854775807 on my 64-bit FreeBSD box. The range of generated random numbers is explicitly documented. So I am afraid I should hard-code 2^32-1 in the file. Chenguang Li -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJT/zoTAAoJELG4cS+11lRhycwQALj9YTuHZGW3XVZfq83F+jNu u2mPZP6WarsAwWOUVGKJJEn0+E9TLe72lmIgSVoD+h27Y3lOye3kJ1Hpgx38sXVd Zn554Qi15wbuKDJMUDitJEeBFqlE+9NibVip7UsvzXMAkbGZonJTUAqopz7rXJmY IVZWblq63CUsPa+bz8eQ798jpAB7K+9QAkKaYyllTto0sNBWwCS+ZBO1IV2QzCw6 +BnVlQAioG1Z3cGc4j6lCxED/jGVL0A8dbXa+Eg8x95XfNCJnNDsahwqLBC1P0P7 1pZqJEa4UyLih4QK7msWRqGWXIgnzaytVbLMFEey8pYtc0y3lcHwdvzMgmQ55rvR V9UM68ux2ArcR8OuCKNC/KHPaqzx8RYhmFWj5bwkTylAYrkPbBqb9Ws5L8kBLpLz bn90ofOH+mDzsEyIdoV0C7wFDv0Niu9qubr2qhe2qnSsqQ2lUkIQXIFbSnKfvs1y y3tPB2j1NKVCW6+6S/0oACxOpSAVYuSxzAQqkK/JKvedoJT1/pCmLDTuceAa5Vau E1oCx2pA/8mrB64KNla3dmumSl6cx0bbA0LZb1pByIdlDfqTBaxpKLcBrWchaYnA IN2VVTnJwDv9AXf9BqgwPPRZoTq8JkYwdVT9fS2NniWBnP1l+b/FR5RDBOR6e+MH Ds5aPNGsbbNwGKKSRNWl =m/Rg -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B6FE2E90-A51B-4ABF-97E2-29881215F95F>