Date: Tue, 26 May 2009 17:49:44 +0900 (JST) From: Maho NAKATA <chat95@mac.com> To: pav@FreeBSD.org Cc: pgollucci@p6m7g8.com, itetcu@FreeBSD.org, naylor.b.david@gmail.com, freebsd-ports@FreeBSD.org Subject: Re: MAKE_JOBS_UNSAFE (some more ports) Message-ID: <20090526.174944.67896045.chat95@mac.com> In-Reply-To: <1243327705.43470.8.camel@pav.hide.vol.cz> References: <20090526.111343.48515131.chat95@mac.com> <200905260819.23178.naylor.b.david@gmail.com> <1243327705.43470.8.camel@pav.hide.vol.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Tue_May_26_17_49_44_2009_078)--
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
From: Pav Lucistnik <pav@FreeBSD.org>
Subject: Re: MAKE_JOBS_UNSAFE (some more ports)
Date: Tue, 26 May 2009 10:48:25 +0200
> David Naylor p=ED=B9e v =FAt 26. 05. 2009 v 08:19 +0200:
> =
>> pav: ${_MAKE_JOBS:C/-j//} won't work with DISABLE_MAKE_JOBS (or =
>> MAKE_JOBS_UNSAFE) since it needs to always be a positive number, sec=
ondly it =
>> still cannot be used for conditional code (since it is defined in th=
e post =
>> section, but the whole code could always be moved to the pre section=
). =
> =
> I'm hesitant to modify bsd.port.mk for benefit of just four ports.
> Also, I think having MAKE_JOBS_NUMBER set to 1 when the feature is in=
> fact disable, is counter-intuitive (because -j1 is very different to =
no
> -j at all).
> =
> So how about just having
> =
> .if defined(DISABLE_MAKE_JOBS)
> MAKE_JOBS_NUMBER=3D 1
> .else
> MAKE_JOBS_NUMBER!=3D echo `${SYSCTL} -n kern.smp.cpus`
> .endif
> =
> in ooo makefile?
for me ok.
thank you
-- Nakata Maho http://accc.riken.jp/maho/ , http://ja.openoffice.org/ =
Nakata Maho's PGP public keys: http://accc.riken.jp/maho/maho.pgp.tx=
t
----Security_Multipart(Tue_May_26_17_49_44_2009_078)--
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (FreeBSD)
iEYEABECAAYFAkobrSgACgkQpcQqaPiEzfmYmACgvBz6FczPYnEQ9iNtYmFAqTdo
8GwAn0/HzRsg/SmqQI0d8ItDQnk76Jp+
=huot
-----END PGP SIGNATURE-----
----Security_Multipart(Tue_May_26_17_49_44_2009_078)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090526.174944.67896045.chat95>