Date: Wed, 4 Jan 2017 01:44:45 +0000 (UTC) From: Ngie Cooper <ngie@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r311222 - head/usr.sbin/bsnmpd/tools/libbsnmptools Message-ID: <201701040144.v041iji4013585@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: ngie Date: Wed Jan 4 01:44:45 2017 New Revision: 311222 URL: https://svnweb.freebsd.org/changeset/base/311222 Log: Fix logical inversion when checking result from calloc in snmp_output_err_resp(..) X-MFC with: r310987 MFC after: 3 days Reported by: Coverity CID: 1368195 Modified: head/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c Modified: head/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c ============================================================================== --- head/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c Wed Jan 4 01:38:07 2017 (r311221) +++ head/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c Wed Jan 4 01:44:45 2017 (r311222) @@ -2011,7 +2011,7 @@ snmp_output_err_resp(struct snmp_toolinf return; } - if ((object = calloc(1, sizeof(struct snmp_object))) != NULL) { + if ((object = calloc(1, sizeof(struct snmp_object))) == NULL) { fprintf(stdout, "calloc: %s", strerror(errno)); return; }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201701040144.v041iji4013585>