From owner-freebsd-ports@FreeBSD.ORG Tue Jan 20 05:59:52 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 60CB316A4CE; Tue, 20 Jan 2004 05:59:52 -0800 (PST) Received: from postman.arcor.de (postman4.arcor-online.net [151.189.0.189]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8AFE143D3F; Tue, 20 Jan 2004 05:59:46 -0800 (PST) (envelope-from eikemeier@fillmore-labs.com) Received: from fillmore.dyndns.org (port-212-202-51-21.reverse.qsc.de [212.202.51.21]) (authenticated bits=0)i0KDxjM4027972 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Tue, 20 Jan 2004 14:59:45 +0100 (MET) Received: from [172.16.0.2] (helo=fillmore-labs.com) by fillmore.dyndns.org with esmtp (SSLv3:AES256-SHA:256) (Exim 4.30; FreeBSD) id 1AiwPw-000277-R6; Tue, 20 Jan 2004 14:59:44 +0100 Message-ID: <400D344B.6010403@fillmore-labs.com> Date: Tue, 20 Jan 2004 14:59:39 +0100 From: Oliver Eikemeier Organization: Fillmore Labs GmbH - http://www.fillmore-labs.com/ MIME-Version: 1.0 To: Eivind Eklund References: <1074590694.85583.20.camel@shumai.marcuscom.com> <400D2939.5090203@fillmore-labs.com> <20040120133020.GB94636@FreeBSD.org> In-Reply-To: <20040120133020.GB94636@FreeBSD.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit User-Agent: KMail/1.5.9 cc: ports@FreeBSD.org cc: Joe Marcus Clarke cc: Kris Kennaway Subject: Re: HEADS UP: New bsd.*.mk changes X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2004 13:59:52 -0000 Eivind Eklund wrote: > On Tue, Jan 20, 2004 at 02:12:25PM +0100, Oliver Eikemeier wrote: > >>Joe Marcus Clarke wrote: >> >>>Type: FEATURE >>> >>>Title: Add per-port persistent build options with a menu-driven >>>front-end >>> >>>[...] >> >>Sorry for stepping up so late, but this saves options under >> ${PORT_DBDIR}/${PORTNAME}/options >> >>Lots of ports have the same PORTNAME (ie 'openldap' for >>net/openldap2[012]-(client|server), 'apache' for russian/apache13, >>www/apache(13|13-fp|2|21)). Some conflict, but -client/-server don't. >>Either each port has to set OPTIONSFILE to >>${PORT_DBDIR}/${PORTNAME}/something, >>or we may use LATEST_LINK instead of PORTNAME: > > I can't have any particularly reasoned opinion either way - the use > of PORTNAME is inherited from kris, who replaced storing in a file > in the port source directory with the use of PORTNAME (IMO, a large > improvement). And I thought it was supposed to be unique, while it seems > it isn't. That said, I think the name LATEST_LINK should be changed (possibly > not right now) if LATEST_LINK is to be used this way. > > Also, I don't see why LATEST_LINK would always be unique - instead, it looks to > me as if there could be conflicts between different ports on this (while I thought > we defined that there shouldn't be for PORTNAME). The problem with the current solution is that renaming OPTIONSFILE is not easy, because ${PORT_DBDIR}/${PORTNAME} is somewhat hardcoded in bsd.port.mk now. I can change PORT_DBDIR, but have to accept ${PORT_DBDIR}/${PORTNAME}, which is bad. Perhaps we should have OPTIONSFILE?=${PORT_DBDIR}/${LATEST_LINK}.options, which is easier to change. LATEST_LINK should be unique for each package, and I guess if two ports have the same LATEST_LINK they CONFLICT anyway. But I don't care if we use LATEST_LINK or something else, as long as it is easily changeable in the case of conflicts. -Oliver