Date: Sun, 17 Feb 2013 15:43:22 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Jilles Tjoelker <jilles@stack.nl> Cc: Konstantin Belousov <kostikbel@gmail.com>, Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@des.no>, freebsd-arch@FreeBSD.org Subject: Re: bindat(2) and connectat(2) syscalls for review. Message-ID: <20130217144321.GJ2023@garage.freebsd.pl> In-Reply-To: <20130217142038.GA55034@stack.nl> References: <20130213230354.GC1375@garage.freebsd.pl> <20130213232004.GA2522@kib.kiev.ua> <20130213234030.GD1375@garage.freebsd.pl> <20130214185549.GA36288@stack.nl> <86ip5saqiu.fsf@ds4.des.no> <20130216232039.GD2023@garage.freebsd.pl> <86y5enaan7.fsf@ds4.des.no> <20130217142038.GA55034@stack.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
--k+G3HLlWI7eRTl+h Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 17, 2013 at 03:20:38PM +0100, Jilles Tjoelker wrote: > On Sun, Feb 17, 2013 at 04:21:00AM +0100, Dag-Erling Sm=F8rgrav wrote: > > Pawel Jakub Dawidek <pjd@FreeBSD.org> writes: > > > Dag-Erling Sm=F8rgrav <des@des.no> writes: > > > > Jilles Tjoelker <jilles@stack.nl> writes: > > > > > A flag parameter is a good thing; you may not know yet what you w= ill > > > > > need it for. > > > > int bind(int s, const struct sockaddr *addr, socklen_t addrlen); > > > > int connect(int s, const struct sockaddr *name, socklen_t namelen); > > > > Where's the flag argument? > > > The is no flag argument in my patch, but it was proposed by Kostik in > > > the e-mail Jilles replied to. >=20 > > That was a rhetorical question... unless Jilles wants to go through our > > entire code base and add a flag argument to every syscall or library > > function that doesn't already have one, "just in case". >=20 > The point is not to add a flags argument everywhere for the sake of it; > rather, to add a flags argument if a function is extended or created > anyway. This leaves some space for future extensibility. >=20 > For example, POSIX considered eaccess() not useful enough, but when > access() was extended to faccessat(), a flag argument was added which > allowed the eaccess() functionality. But if we are going to do that, it would be nice to have at least one useful flag to use in there:) --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl --k+G3HLlWI7eRTl+h Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlEg7IkACgkQForvXbEpPzRkMQCgl22uax6ucfmuYmxp0DrQ9Ufe 19sAoNophK9ls8gYVjnbuTOd9yAOru8j =8o6B -----END PGP SIGNATURE----- --k+G3HLlWI7eRTl+h--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130217144321.GJ2023>