From owner-cvs-all@FreeBSD.ORG Thu Mar 3 15:21:56 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B367C16A4CE; Thu, 3 Mar 2005 15:21:56 +0000 (GMT) Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3ED4843D1D; Thu, 3 Mar 2005 15:21:56 +0000 (GMT) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) j23FLqYX016002; Thu, 3 Mar 2005 10:21:55 -0500 (EST) Date: Thu, 3 Mar 2005 10:21:52 -0500 (EST) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Scott Long In-Reply-To: <422719E0.10703@samsco.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net) cc: cvs-src@freebsd.org cc: cvs-all@freebsd.org cc: src-committers@freebsd.org cc: David Xu cc: John Baldwin Subject: Re: cvs commit: src/sys/kern kern_sig.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2005 15:21:56 -0000 On Thu, 3 Mar 2005, Scott Long wrote: > > It's not about convenience or taking the easy way out. Let's fix > sigwait() to have the proper assumptions and go from there. I'm > inclined to agree with John that the problem is not widespread or > impossible to track down. Fixing it is not hard either, we already have > the PHOLD()/PRELE() functions for doing exactly what is needed here. Can you add assertions in msleep(), cv_wait(), etc, to panic if the object is on the kernel stack and the stack is swappable? -- DE