From owner-freebsd-current@freebsd.org Tue Oct 15 16:23:58 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5D74614CF1E for ; Tue, 15 Oct 2019 16:23:58 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 46t12k0ttXz4StK for ; Tue, 15 Oct 2019 16:23:57 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id x9FGNuTS033316 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 15 Oct 2019 09:23:56 -0700 (PDT) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id x9FGNtMV033315; Tue, 15 Oct 2019 09:23:55 -0700 (PDT) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Tue, 15 Oct 2019 09:23:55 -0700 From: Gleb Smirnoff To: Thomas Mueller Cc: freebsd-current@freebsd.org Subject: Re: sweeping change over all NIC drivers Message-ID: <20191015162355.GM4086@FreeBSD.org> References: <20191014210736.GG4086@FreeBSD.org> <201910150308.x9F38t3S029236@cell.glebi.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201910150308.x9F38t3S029236@cell.glebi.us> User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 46t12k0ttXz4StK X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.88 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.88)[-0.878,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Oct 2019 16:23:58 -0000 On Tue, Oct 15, 2019 at 02:25:15AM +0000, Thomas Mueller wrote: T> > The stack changes froim the review are already committed, T> > only a bunch of drivers are left. You can browse them as T> > individual commits here: T> T> > https://github.com/glebius/FreeBSD/commits/if_foreach_maddr T> T> > Although changes are close to trivial, there is always a place T> > for a mistake. So reviewing is appreciated. Testing is even T> > more appreciated. Here is list of drivers affected (65 total): T> T> (re and rtwn included but not rsu) rsu is already committed, since Hand reviewed it. T> I built FreeBSD 12-stable and current five months ago, and they have been sitting rather idle because of no internet access with current, and possible but very awkward with 12-stable. T> T> Only good thing I got was efibootmgr. T> T> I assume these changes are only for FreeBSD-current now and have to be tested and proven before committing to releng 12. T> T> But I am working on other things now on the computer and will not be able to get to FreeBSD-current immediately. These changes are for FreeBSD 13 only and are not planned to be merged. -- Gleb Smirnoff