Date: Wed, 12 Apr 2000 01:44:29 +0900 From: "Akinori -Aki- MUSHA" <knu@idaemons.org> To: imura@af.airnet.ne.jp Cc: asami@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/chinese Makefile.inc ports/german Makefile.inc ports/japanese Makefile.inc ports/korean Makefile.inc ports/russian Makefile.inc ports/vietnamese Makefile.inc Message-ID: <86bt3gk2oi.wl@archon.local.idaemons.org> In-Reply-To: In your message of "Wed, 12 Apr 2000 00:57:30 %2B0900" <20000412005730F.imura@cs.titech.ac.jp> References: <86hfd9rzkz.wl@archon.local.idaemons.org> <86d7nxrtbj.wl@archon.local.idaemons.org> <vqc4s99ox22.fsf@silvia.hip.berkeley.edu> <20000412005730F.imura@cs.titech.ac.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
At Wed, 12 Apr 2000 00:57:30 +0900,
imura wrote:
> > +.if ${MASTERDIR} != ${.CURDIR} && exists(${.CURDIR}/../Makefile.inc)
> > +.include "${.CURDIR}/../Makefile.inc"
> > +.endif
> > +
> > .if exists(${MASTERDIR}/../Makefile.inc)
> > .include "${MASTERDIR}/../Makefile.inc"
> > .endif
>
> Why not just do like this?
>
> .if exists(${.CURDIR}/../Makefile.inc)
> .include "${.CURDIR}/../Makefile.inc"
> .endif
I'm not sure what you're suggesting.
1) You mean a port should not include ${MASTERDIR}/../Makefile.inc?
But we need to include it to have some category specific settings in
future.
2) You mean a port should not check if ${MASTERDIR} != ${.CURDIR}?
But we need to check it in order never to include a file twice.
Imagine a case when a slave and the master were in the same category.
> > * I think it'd be bad if every slave port were to be forced to include
> > * `${.CURDIR}/../Makefile.inc' for itself before including
> > * `${MASTERDIR}/Makefile', so I'd suggest we prepare some files as
> > * follows:
>
> I don't understand this part.
>
> For example, korean/Wnn:
>
> 1. Read korean/Wnn/Makefile
> 2. Read ${MASTERDIR(= japanese/Wnn)/Makefile
> 3. Read Mk/bsd.port.pre.mk
> 4. Read ${.CURDIR(= korean/Wnn)}/../Makefile.inc
> 5. Return to ${MASTERDIR}/Makefile
> 6. Read Mk/bsd.port.post.mk
>
> So, I think, including ${.CURDIR}/../Makefile.inc before
> including ${MASTERDIR}/Makefile never occurs.
We need to include both ${.CURDIR}/../Makefile.inc and
${MASTERDIR}/../Makefile.inc (in the order named) for the reason I
mentioned above in 1).
--
/
/__ __
/ ) ) ) ) /
Akinori -Aki- MUSHA aka / (_ / ( (__( <knu@idaemons.org>
"If you choose not to decide you still have made a choice."
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86bt3gk2oi.wl>