Date: Sat, 27 Jan 2018 21:48:40 +0100 From: Emmanuel Vadot <manu@bidouilliste.com> To: Adrian Chadd <adrian.chadd@gmail.com> Cc: Poul-Henning Kamp <phk@phk.freebsd.dk>, Warner Losh <imp@bsdimp.com>, John Baldwin <jhb@freebsd.org>, Ravi Pokala <rpokala@mac.com>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328257 - in head/sys: arm/broadcom/bcm2835 dts/arm modules Message-ID: <20180127214840.dc033d582696ff7b51f6d7e6@bidouilliste.com> In-Reply-To: <CAJ-VmonVwK4pkyxGqfwaNwQ89GdYAaamjBYZHxbjTcuZcEqDsw@mail.gmail.com> References: <201801220710.w0M7AUm9091853@repo.freebsd.org> <CANCZdfpq2QoG4EAj0VW2FF=4VXRv-qQKFfJTJerWH9YOwVoVBA@mail.gmail.com> <90451.1516663240@critter.freebsd.dk> <2987003.eeGRFBb6N8@ralph.baldwin.cx> <CANCZdfrh0NHq7cbkq_genEdzo%2BB3G4TTAcEzpgh11sr%2B82e9aw@mail.gmail.com> <93949.1516733748@critter.freebsd.dk> <20180127210801.37b8001125dd0a2c92372f98@bidouilliste.com> <CAJ-VmonVwK4pkyxGqfwaNwQ89GdYAaamjBYZHxbjTcuZcEqDsw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 27 Jan 2018 12:13:57 -0800 Adrian Chadd <adrian.chadd@gmail.com> wrote: > Hi, > > Find the middle ground. Don't dissuade the developer too much. This is what happened two years ago when I started hacking on the allwinner SoCs : - I asked what should be done for bringing a new board - andrew@ told me that we first need to switch to upstream dts and update drivers. - Guess what, I did that. > Here's an example: > > Make the driver follow DTS, allow a tunable/kenv check for it to > override whether it needs to be in the DTS or not (the "keep phk happy > for now" compromise) and have it default to obeying the device tree. > > That way phk is kept happy and the defaults are the same as normal-ish > ARM /and/ you have a springboard to experiment with extending FDT > overlays at runtime for people who wish to do so. I don't care about keeping phk@ (or any other developer) happy, we have a standard, let's stick to it. > (I personally hate having to edit the dts/recompile/reboot for every > test hardware change; it makes breadboarding things up kinda > hilariously annoying.) Use overlays then. And if you don't want to reboot provide patch for loading overlays at runtime. > -adrian -- Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180127214840.dc033d582696ff7b51f6d7e6>