Date: Thu, 08 Sep 2011 15:35:53 +0100 From: Ben Hutchings <bhutchings@solarflare.com> To: Vlad Galu <dudu@dudu.ro> Cc: Takuya ASADA <syuu@dokukino.com>, freebsd-net@freebsd.org Subject: Re: Adding Flow Director sysctls to ixgbe(4) Message-ID: <1315492556.23168.45.camel@deadeye> In-Reply-To: <ADC8BD0D-6AC2-4D15-B8C3-FC2F244D8051@dudu.ro> References: <CALG4x-W99OZxd=1ZDvW4=MBqeE3RPOazc7jc_3O30X-Pou3k8Q@mail.gmail.com> <1315221674.3092.282.camel@deadeye> <CALG4x-UYy-zUir%2Bqz37mm6D4Eo_cAErSPMZMx5ScvyfPiN4zfw@mail.gmail.com> <ADC8BD0D-6AC2-4D15-B8C3-FC2F244D8051@dudu.ro>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 2011-09-08 at 10:55 +0200, Vlad Galu wrote: > On Sep 8, 2011, at 10:11 AM, Takuya ASADA wrote: > > Hi, > > > > 2011/9/5 Ben Hutchings <bhutchings@solarflare.com>: > >> On Mon, 2011-09-05 at 15:51 +0900, Takuya ASADA wrote: > >>> Hi, > >>> > >>> I implemented Ethernet Flow Director sysctls to ixgbe(4), here's a detail: > >>> > >>> - Adding removing signature filter > >>> On linux version of ixgbe driver, it has ability to set/remove perfect > >>> filter from userland using ethtool command. > >>> I implemented similar feature, but on sysctl, and not perfect filter > >>> but signature filter(which means hash collision may occurs). > >> [...] > >> > >> Linux also has a generic interface to RX filtering and hashing > >> (ethtool_rxnfc) which ixgbe supports; wouldn't it be better for FreeBSD > >> to support something like that? > >> > >> Ben. > > > > Linux implement it on ethtool command, what should we do? > > Maybe a new option for ifconfig, or provide new command for it? > > I for one would love to see this functionality built into ifconfig. > Linux always seems to have one tool too many. There's ifconfig, > iproute2, route, mii-tool and ethtool. The current tools are iproute2 (replacing ifconfig and route) and ethtool. mii-tool might still be useful for debugging a 10M or 100M driver, but ethtool can display anything an administrator would be interested in. Now you could quite reasonably say that the improvements made in iproute2 ought to have been done without creating a new command. But it is not true that all these different commands are required. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1315492556.23168.45.camel>