Date: Sat, 1 Mar 1997 00:18:23 -0700 (MST) From: Nate Williams <nate@mt.sri.com> To: "Jordan K. Hubbard" <jkh@time.cdrom.com> Cc: Charles Henrich <henrich@crh.cl.msu.edu>, bde@zeta.org.au, freebsd-bugs@freebsd.org Subject: Re: mail.local modifications? Message-ID: <199703010718.AAA18610@rocky.mt.sri.com> In-Reply-To: <1934.857198413@time.cdrom.com> References: <199703010629.BAA09181@crh.cl.msu.edu> <1934.857198413@time.cdrom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[
Jordan, you need to get a better mail program that doesn't trash
quoted lines. Thanks goodness VM fixes them with a little help. :)
]
>> And thats one hudred percent and completely acceptable and accepted
>> behavior. The problem is that the patch DID work, I didnt
>> cut'n'paste, I read it in with VI, made extra sure it was perfect,
>> applied it twice to my source copies, before sending it in. The
>> comment I got back was "its got spaces in it" which it did, and I
>> took as meaning he didnt like my spaces. Not that it didnt apply.
>
> Ah, I took it the latter way. Bruce, perhaps you'd care to enlighten
> both of us? :-)
If the program was written with tabs (as most programs are), and a
person uses spaces in their diff, it makes things really obnoxious when
someone brings it up in an editor that has tabs set to be 4-spaces wide.
If you don't keep the style consistant, you end up with sources that
look like this (an exaggeration obviously).
int
method(foo,bar, bletch)
int foo;
char* bar;
long *bletch;
{
int i;
for(i=0;i<2;i++)
{
if ( i == 1 ) {
i += 2;
} else {
printf("i=%d\n");
}
}
}
vs.
int
method(foo, bar, bletch)
int foo;
char *bar;
long *bletch;
{
int i;
for (i = 0; i < 2; i++) {
if ( i == 1 )
i += 2;
else
printf("i=%d\n");
}
}
(Although, some of us prefer 4-space tabs. :)
Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199703010718.AAA18610>