Date: Mon, 3 Jan 2011 09:55:30 -0800 From: Garrett Cooper <yanegomi@gmail.com> To: =?utf-8?Q?Edward_Tomasz_Napiera=C5=82a?= <trasz@FreeBSD.org> Cc: Kostik Belousov <kostikbel@gmail.com>, Matthias Andree <matthias.andree@gmx.de>, "freebsd-current@freebsd.org" <freebsd-current@freebsd.org> Subject: Re: No human readable message with g_vfs Message-ID: <F5FB1B76-21A9-42E6-8294-BA4F6E8EA8DA@gmail.com> In-Reply-To: <47B52F19-AB6B-4116-9F5E-219B26519115@FreeBSD.org> References: <4D1B0E41.40405@gmail.com> <ifsi3f$5ub$1@dough.gmane.org> <4D21CC35.5060803@gmx.de> <20110103141830.GC3140@deviant.kiev.zoral.com.ua> <47B52F19-AB6B-4116-9F5E-219B26519115@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jan 3, 2011, at 8:33 AM, Edward Tomasz Napiera=C5=82a <trasz@FreeBSD.org>= wrote: > Wiadomo=C5=9B=C4=87 napisana przez Kostik Belousov w dniu 2011-01-03, o go= dz. 15:18: >> On Mon, Jan 03, 2011 at 02:16:37PM +0100, Matthias Andree wrote: >>> Am 03.01.2011 14:14, schrieb Ivan Voras: >>>> On 12/29/10 11:32, David Demelier wrote: >>>>> /var/log/messages.5.bz2:Nov 29 16:36:52 Abricot kernel: >>>>> g_vfs_done():ufs/public[READ(offset=3D232718991360, length=3D131072)]e= rror >>>>> =3D 5 >>>>>=20 >>>>> I think for a lambda user these are absolutely not understandable. I >>>>=20 >>>> Would a better message be "WRITE error on da0, offset=3D34590720. >>>> length=3D65536, errno=3D5"? >>>=20 >>> nah, strerror(errno) isn't that much of an effort >> In kernel ? There is no strerror, and there is no great need to import th= e >> sys_errlist. >=20 > I had code that adds strerror() to the kernel in one of my old p4 branches= . > Error messages like the one above look much better this way, but I didn't > have time to push it into the tree, and there is a risk of yet another i18= n > discussion. If someone is interested - let me know; I'll try to find it. Some thoughts: - It's a pain to parse (before I just had to scan for an int -- now it's a s= tring?!?) - It slows down printing (slow kernel -> dog slow system). - Fills up logs quicker if a subsystem or piece of hardware is going south a= nd these messages slam syslog, which means I have to scan more logs looking f= or useful data, the likelihood of messages being lost in various buffers is h= igher, etc. Why not just provide a more standard sensical printout for the messages and p= rovide a secret decoder ring in userland or something for interested parties= the don't know that error is an errno value (eg my mom and dad because they= 're unix illiterate), or just copyout all of the error data via an ioctl, pr= int out the ioctl failures, and skip the kernel level printing altogether? Thanks! -Garrett=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F5FB1B76-21A9-42E6-8294-BA4F6E8EA8DA>