Date: Sat, 13 Mar 2004 17:09:48 -0800 From: Kris Kennaway <kris@obsecurity.org> To: Oliver Eikemeier <eikemeier@fillmore-labs.com> Cc: Oliver Eikemeier <eik@FreeBSD.org> Subject: Re: ports/64233: [PATCH] bsd.port.mk: improved OPTIONS handling Message-ID: <20040314010948.GA85506@xor.obsecurity.org> In-Reply-To: <4053AE29.7070802@fillmore-labs.com> References: <200403132222.i2DMM4qs070344@freefall.freebsd.org> <1079217571.13553.9.camel@shumai.marcuscom.com> <4053A92D.6010804@fillmore-labs.com> <1079224702.13553.51.camel@shumai.marcuscom.com> <4053AE29.7070802@fillmore-labs.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--uAKRQypu60I7Lcqm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 14, 2004 at 01:58:17AM +0100, Oliver Eikemeier wrote: > That should be easy to resolve, but I'll appreciate some feedback before > I develop a solution. First of all, when BATCH or PACKAGE_BUILDING is set, > default options are used and no configuration dialog is presented. >=20 > So we can either set BATCH in INDEX builds or add another variable, like > DISABLE_CONFIG. BATCH may be appropriate, but it will require careful testing to make sure it does the right thing. For example, end users want INDEX builds to use their local options and make.conf settings, but package builds need to use the default settings without picking up anything from the local system. Currently I override LOCALBASE and X11BASE, and __MAKE_CONF to prevent package index builds from seeing installed host packages and system settings. > The issues here are: >=20 > - To generate default options I need to write them to a file. Currently > I'm using the real OPTIONSFILE, so after a `make index' you have a > saved default configuration for all ports that define OPTIONS. Maybe > a temporary file would be a better solution here? A temporary file may be the way to go; if the options are stored in the system directory, then if the user builds INDEX and later builds the port, they won't be presented with the config dialog and the port will just silently use the default options. > - I'm not sure what this does to running times of INDEX builds. That's a very important one. The initial OPTIONS processing patch already slowed down index builds by ~10% because it spawns a shell to check the options file for every port. I mentioned this to marcus shortly after it was committed, but I don't know to what extent it was followed up (it's not yet fixed). Kris --uAKRQypu60I7Lcqm Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAU7DcWry0BWjoQKURAk5iAJwNiU/LteV8+TDty7qIElPJ/NPkDwCdEd9k 40M5OHOY9gWtDO0pr5fUg3g= =igw/ -----END PGP SIGNATURE----- --uAKRQypu60I7Lcqm--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040314010948.GA85506>