From owner-svn-ports-all@freebsd.org Fri Dec 22 15:08:30 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7267AE9EEE0; Fri, 22 Dec 2017 15:08:30 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 50D7D7A34D; Fri, 22 Dec 2017 15:08:30 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 9640C44C5; Fri, 22 Dec 2017 15:08:29 +0000 (UTC) Date: Fri, 22 Dec 2017 15:08:29 +0000 From: Alexey Dokuchaev To: Lars Engels Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r456640 - in head/audio/volumeicon: . files Message-ID: <20171222150829.GA40572@FreeBSD.org> References: <201712181625.vBIGPW1e085627@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201712181625.vBIGPW1e085627@repo.freebsd.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Dec 2017 15:08:30 -0000 On Mon, Dec 18, 2017 at 04:25:32PM +0000, Lars Engels wrote: > New Revision: 456640 > URL: https://svnweb.freebsd.org/changeset/ports/456640 > > Log: > audio/volumeicon: > > - Add OSS v3 backend [1] > - Fix mixer channel selection in Preferences/Channels > - Bump PORTREVISION > > [...] > Added: head/audio/volumeicon/files/patch-configure.ac > ... > @@ -0,0 +1,20 @@ > +--- configure.ac.orig 2015-03-02 23:54:36.000000000 +0100 > ++++ configure.ac 2017-12-18 17:23:45.215876000 +0100 Hmm, any reason why patches were not generated with ``make makepatch''? > Modified: head/audio/volumeicon/files/patch-data_gui_preferences.ui > @@ -1,5 +1,5 @@ > ---- data/gui/preferences.ui.orig 2017-12-12 18:43:30 UTC > -+++ data/gui/preferences.ui > +--- data/gui/preferences.ui.orig 2015-03-02 23:54:36.000000000 +0100 > ++++ data/gui/preferences.ui 2017-12-18 17:23:45.219716000 +0100 > @@ -197,7 +197,7 @@ > > True The contents of the patch did not change, only the header. Why wasn't it excluded from the commit batch? > +--- src/Makefile.am.orig 2015-03-02 23:54:36.000000000 +0100 > ++++ src/Makefile.am 2017-12-18 17:23:45.222731000 +0100 Ditto (no ``make makepatch'' => bad timestamps). > Added: head/audio/volumeicon/files/patch-src_oss3__backend.c > ... > +--- src/oss3_backend.c.orig 2017-12-18 17:23:45.225185000 +0100 > ++++ src/oss3_backend.c 2017-12-18 17:23:57.906175000 +0100 > +@@ -0,0 +1,185 @@ ^^^^ Ouch. New files should be put to ${FILESDIR} as is, not as a patch to a non-existent file. Patches are for modifying pre-existing files; creating new ones via patch is bad practice. This also produced convoluted diffs with future updates. > Modified: head/audio/volumeicon/files/patch-src_oss__backend.h > ... > @@ -1,5 +1,5 @@ > ---- src/oss_backend.h.orig 2015-03-02 22:54:36 UTC > -+++ src/oss_backend.h > +--- src/oss_backend.h.orig 2015-03-02 23:54:36.000000000 +0100 > ++++ src/oss_backend.h 2017-12-18 17:23:45.233327000 +0100 > @@ -35,5 +35,7 @@ int oss_get_volume(); > gboolean oss_get_mute(); > const gchar * oss_get_channel(); Ditto: useless changes (repo churn), timestamp pessimization. > Modified: head/audio/volumeicon/files/patch-src_volumeicon.c > ... > @@ -1,5 +1,5 @@ > ---- src/volumeicon.c.orig 2015-03-02 22:54:36 UTC > -+++ src/volumeicon.c > +--- src/volumeicon.c.orig 2015-03-02 23:54:36.000000000 +0100 > ++++ src/volumeicon.c 2017-12-18 17:23:45.237664000 +0100 > @@ -1295,6 +1295,8 @@ int main(int argc, char * argv[]) > backend_get_mute = &oss_get_mute; > backend_get_channel = &oss_get_channel; Ditto. Please review your commit batch prior to commit with "svn st" and "svn diff". ./danfe