Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 7 Nov 2016 19:27:28 +0100
From:      Hans Petter Selasky <hps@selasky.org>
To:        Oleksandr Tymoshenko <gonzo@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r308424 - head/sys/arm/broadcom/bcm2835
Message-ID:  <f8169b11-56d8-4566-f9e9-e387dd9b939e@selasky.org>
In-Reply-To: <201611071738.uA7HceYu045944@repo.freebsd.org>
References:  <201611071738.uA7HceYu045944@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 11/07/16 18:38, Oleksandr Tymoshenko wrote:
> +		bcm2835_audio_unlock(sc);
> +		cv_signal(&sc->worker_cv);


Shouldn't cv_signal() be done locked, so that you don't loose any 
transactions? CV's only wakeup the treads that are sleeping right there 
and then.

--HPS



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f8169b11-56d8-4566-f9e9-e387dd9b939e>