From owner-svn-ports-all@freebsd.org Sat Sep 19 11:59:52 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9E3FCA034AB; Sat, 19 Sep 2015 11:59:52 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 717B11DE7; Sat, 19 Sep 2015 11:59:51 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from [192.168.1.20] (163.Red-81-44-5.dynamicIP.rima-tde.net [81.44.5.163]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 6B29843C03; Sat, 19 Sep 2015 06:59:44 -0500 (CDT) Subject: Re: svn commit: r396998 - head/net/samba36 To: Alexey Dokuchaev References: <201509151622.t8FGMXQY074723@repo.freebsd.org> <0FAE77426236E9E47E15BFC1@atuin.in.mat.cc> <20150919072048.GA86129@FreeBSD.org> <55FD0FA4.7050306@marino.st> <20150919074241.GA96797@FreeBSD.org> <55FD3620.7060500@marino.st> <20150919115157.GA99928@FreeBSD.org> Cc: Mathieu Arnold , "Timur I. Bakeyev" , Dmitry Marakasov , ports-committers@freebsd.org, svn-ports-all , svn-ports-head From: John Marino X-Enigmail-Draft-Status: N1110 Reply-To: marino@freebsd.org Message-ID: <55FD4E2D.7000907@marino.st> Date: Sat, 19 Sep 2015 13:59:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <20150919115157.GA99928@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Sep 2015 11:59:52 -0000 On 9/19/2015 1:51 PM, Alexey Dokuchaev wrote: > On Sat, Sep 19, 2015 at 12:17:04PM +0200, John Marino wrote: >> On 9/19/2015 9:42 AM, Alexey Dokuchaev wrote: >>> I'm fine with clear and umabiguous rules too. I just want bumping rules >>> to become more granular. Plain "package changed -> need a bump" means >>> that fixing a typo in pkg-descr would require it. Don't you think this >>> is a bit too extreme? >> >> I think there is already an exception for metadata changes such as >> pkg-descr and COMMENT and MAINTAINER, although I don't know if this >> exception is documented (it is done in practice). However shebang fixes >> are functional and definitely need a bump. They can be the difference >> between functioning and non-functioning packages. > > Right; however, in this particular case it was *examples* what were fixed, > which in fact are not ready to be run on FreeBSD as is. I can totaly see > why Timur got upset about this particular bump. Hmm. Two things: 1) why are non-functional examples getting installed? I can flip this and get "upset" that broken examples are provided by the port. 2) Let's say the example did work except for the shebangs. I still support bumping in that case. Why should examples be less priority than the main software? Broken is broken and the presence of examples implies they are useful. Or in other words, if this port had not been installing broken examples in the first place, the shebang fix never would have been made. So I don't think Timur has a good reason to be upset since it traces back to him (I presume from this thread). John