Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 27 Aug 2016 21:34:27 +0000 (UTC)
From:      John Marino <marino@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r420999 - head/www/lessc
Message-ID:  <201608272134.u7RLYRIj045102@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: marino
Date: Sat Aug 27 21:34:27 2016
New Revision: 420999
URL: https://svnweb.freebsd.org/changeset/ports/420999

Log:
  www/lessc: Moving building out of stage phase, fix stage-QA
  
  This port would build and install in the stage phase, but building is
  supposed to be complete by then.  Moreover, stage QA checks complain
  about thousands of "orphaned" files and symbolic links with absolute
  paths.  Fix all the problems by installing in a temporary build directory
  and moving just the lessc files over the stage directory, and fix the
  symbolic link by defining a relative path instead.
  
  Functionally, the new package is the same as the old one, so no revbump
  is required.
  
  PR:		210567
  Approved by:	maintainer timeout (2 months)

Modified:
  head/www/lessc/Makefile

Modified: head/www/lessc/Makefile
==============================================================================
--- head/www/lessc/Makefile	Sat Aug 27 20:39:11 2016	(r420998)
+++ head/www/lessc/Makefile	Sat Aug 27 21:34:27 2016	(r420999)
@@ -14,14 +14,26 @@ LICENSE=	APACHE20
 BUILD_DEPENDS=	npm>=0:www/npm
 RUN_DEPENDS=	npm>=0:www/npm
 
-NO_BUILD=	yes
 USE_GITHUB=	yes
 GH_ACCOUNT=	less
 GH_PROJECT=	less.js
 
+# npm install both builds and installs.  To avoid building in the stage phase,
+# allow npm to install in a temporary directory and move from there.
+# Moreover, only a fraction of what is installed by npm needs to be packaged
+do-build:
+	${MKDIR} ${WRKDIR}/build-lib
+	(cd ${WRKDIR}/build-lib && \
+		${SETENV} HOME=${WRKDIR} npm install ${WRKSRC})
+
 do-install:
-	(cd ${STAGEDIR}${PREFIX}/lib ; ${SETENV} HOME=${WRKDIR} npm install ${WRKSRC})
-	# this is a dirty hack
-	${LN} -s ${PREFIX}/lib/node_modules/.bin/lessc ${STAGEDIR}${PREFIX}/bin/lessc
+	${MKDIR} ${STAGEDIR}${PREFIX}/bin \
+		${STAGEDIR}${PREFIX}/lib/node_modules/.bin
+	${MV} ${WRKDIR}/build-lib/node_modules/less \
+		${STAGEDIR}${PREFIX}/lib/node_modules
+	${MV} ${WRKDIR}/build-lib/node_modules/.bin/lessc \
+		${STAGEDIR}${PREFIX}/lib/node_modules/.bin
+	(cd ${STAGEDIR}${PREFIX}/bin && \
+		${LN} -s ../lib/node_modules/.bin/lessc lessc)
 
 .include <bsd.port.mk>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201608272134.u7RLYRIj045102>