From owner-svn-src-all@freebsd.org  Fri Oct 23 11:11:47 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D27FBA1C085;
 Fri, 23 Oct 2015 11:11:47 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9A6031120;
 Fri, 23 Oct 2015 11:11:47 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from laptop015.home.selasky.org
 (cm-176.74.213.204.customer.telag.net [176.74.213.204])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id B022C1FE023;
 Fri, 23 Oct 2015 13:11:43 +0200 (CEST)
Subject: Re: svn commit: r289811 - head/sys/dev/usb/wlan
To: Andriy Voskoboinyk <avos@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201510230826.t9N8QQgU088757@repo.freebsd.org>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <562A1655.4030503@selasky.org>
Date: Fri, 23 Oct 2015 13:13:25 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <201510230826.t9N8QQgU088757@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Oct 2015 11:11:47 -0000

On 10/23/15 10:26, Andriy Voskoboinyk wrote:
>   static int
>   urtwn_newstate(struct ieee80211vap *vap, enum ieee80211_state nstate, int arg)
>   {
> @@ -1530,7 +1541,6 @@ urtwn_newstate(struct ieee80211vap *vap,
>   	struct urtwn_softc *sc = ic->ic_softc;
>   	struct ieee80211_node *ni;
>   	enum ieee80211_state ostate;
> -	uint32_t reg;

Hi Andriy,

You can quickly test-build the USB kernel modules like this before 
commit, to avoid most cases of kernel build failures:

make -m $PWD/share/mk -C sys/modules/usb/ clean cleandepend
make -m $PWD/share/mk -C sys/modules/usb/ depend all

make -m $PWD/share/mk -C sys/modules/usb/ clean cleandepend
make -m $PWD/share/mk -C sys/modules/usb/ DEBUG_FLAGS="-DUSB_DEBUG" 
depend all

I've simply restored a line you removed in r289811 in r289821 for now. 
If this was not correct or more changes should have been done, then 
please fix.

Good luck with updating the USB WLAN drivers.

--HPS