Date: Mon, 25 Mar 1996 13:51:58 -0800 (PST) From: "JULIAN Elischer" <julian@ref.tfs.com> To: davidg@Root.COM Cc: pst@shockwave.com, freebsd-current@freebsd.org Subject: Re: async mounts, etc. Message-ID: <199603252151.NAA06134@ref.tfs.com> In-Reply-To: <199603252002.MAA06245@Root.COM> from "David Greenman" at Mar 25, 96 12:02:26 pm
next in thread | previous in thread | raw e-mail | index | archive | help
> > I agree with this.. And I've told terry as much.. we are all rather busy.. (I'm presently doing 2 jobs) and while we sometimes disagree about this or that that terry does, the hard part is if there is something we all agre with, it comes with all the added changes, all mixed in.. so it takes a lot to separate them out and we don't HAVE a lot of time.. I put his system startup changes in because 1/ I needed them 2/ they were easily separatable.. > > The mount of controversy is directly proportional to the amount of > non-related changes that are simultaneously submitted (mixed in with the > rest). Both John and I keep looking at Terry's stuff and asking "Hmmm, how can > we extract just the substance of this". A sure-fire way to cause the code to > not be committed is to make "single entry, single exit" changes at the same > time. I don't care to debate this subject now, but I do want to make something > clear: whether you have commit authority or not, I *strongly* encourage that > changes be localized to the task at hand - especially when the changes must > be reviewed before commit like the ones Terry almost always submits. This > *can* be done. We (john and me) know we can extract the namei/componentname > changes from one of Terry's submissions, for example, but simply haven't had > the time to do it. > Just to clarify my position on the VOP_LOCK layering...I agree in principle > with these changes (as does John D. and Kirk). If Terry is willing to > implement *just* those changes, then we will seriously consider them. I know > it's tempting to fix this or that at the same time or to implement your > personal stylistic changes or whatever. There's too much that can go wrong in > the locking, however, and I must insist that the changes be "localized to the > task". > > -DG > > David Greenman > Core-team/Principal Architect, The FreeBSD Project >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199603252151.NAA06134>