From owner-freebsd-bugs  Thu Jan 16 00:21:30 1997
Return-Path: <owner-bugs>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.4/8.8.4) id AAA09795
          for bugs-outgoing; Thu, 16 Jan 1997 00:21:30 -0800 (PST)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19])
          by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id AAA09789;
          Thu, 16 Jan 1997 00:21:22 -0800 (PST)
Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.3/8.6.9) id TAA28376; Thu, 16 Jan 1997 19:19:54 +1100
Date: Thu, 16 Jan 1997 19:19:54 +1100
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199701160819.TAA28376@godzilla.zeta.org.au>
To: bde@zeta.org.au, dg@root.com
Subject: Re: malloc(..., M_WAITOK) found harmful
Cc: bugs@freebsd.org, dyson@freebsd.org, wollman@freebsd.org
Sender: owner-bugs@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

>   Here are my diffs to combine the maps.

>Index: i386/i386/machdep.c
old>! 		mb_map = kmem_suballoc(kmem_map, &minaddr, &maxaddr, 
old>! 				       round_page(mb_map_size), FALSE);
new>! 		mb_map = kmem_suballoc(kmem_map, (vm_offset_t *)&mbutl, &maxaddr,
new>! 			mb_map_size, FALSE);

Please format code with less than 80 columns, especially when the code was
already formatted that way, and even more especially when the line has to
be split anyway.

The style guide says to use a continuation indent of 4 (indent -ci4), but
this is ugly and rarely used in non-CSRG FreeBSD code.

>Index: vm/vm_kern.c
old>! 			log(LOG_ERR, 
old>! 			    "Out of mbuf clusters - increase maxusers!\n");
new>! 			log(LOG_ERR, "Out of mbuf clusters - increase maxusers!\n");

Similarly.  -ci4 happens to match the right rule (-lp).

Bruce