Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 06 Dec 2007 18:09:53 +0100
From:      Henri Hennebert <hlh@restart.be>
To:        freebsd-cvsweb@FreeBSD.org
Subject:   Wrong revision when a log entry contains  LOG_FILESEPR
Message-ID:  <47582CE1.4080905@restart.be>

next in thread | raw e-mail | index | archive | help
Hello,

When I display /src directory for RELENG_7, cvsweb.cgi display the wrong 
revision for UPDATING.

It is due to a log entry containing a line matching `^={77}$'.

I find that, at least on FreeBSD, rlog always display a file matching 
LOG_REVSEPR before the file separator (LOG_FILESEPR).

I propose the following patch against cvsweb.cgi 2.0.6:

--- cvsweb.cgi.orig     2005-09-25 22:28:51.000000000 +0200
+++ cvsweb.cgi  2007-12-06 18:05:47.463195725 +0100
@@ -2570,7 +2570,7 @@
      }

      if ($state eq "log") {
-      if ($_ =~ LOG_REVSEPR || $_ =~ LOG_FILESEPR) {
+      if ($_ =~ LOG_REVSEPR) {

          # End of a log entry.
          my $revbranch = $rev;
@@ -2615,7 +2615,7 @@
        }
      }

-    if ($_ =~ LOG_FILESEPR) {
+    if ($_ =~ LOG_FILESEPR && $rev eq '') {
        $state = "start";
        next;
      }

Hope it help

Henri



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47582CE1.4080905>