From owner-dev-commits-ports-all@freebsd.org Thu Jul 15 16:59:37 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 54B1364A958; Thu, 15 Jul 2021 16:59:37 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GQgZx1kSpz4mNX; Thu, 15 Jul 2021 16:59:37 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1626368377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q9uSzNXxIXhI4u9kKN2bUOwXoPmyw1xuF7LF7bAaskA=; b=ra3GHDrk4QOmgkdtATS4mcSosCySsJcm2nWbB7QIp3blO/i+a6APbsesT2RbfG9Jvcf42z k0bXbC9JOTawm9HWD9Hj1wClQ9awwC/GTMVLj63+9od/Tyahroj59XI2TujJRJ6v+42WnD PUp1Zmh/XnIcSlij9G6pgAHqmilhJEdHTHQCXW5sgk6Jo3xxqhUjBkqg1h8+hcMt/LhVbz mJ+RqIoMdzmX7Hh6XTb1/J8bWRLK17n/dBnhnntaALn2rbO5kya8EFm3+LGWT8H0BzWtTC Bipasi8ED7sM4RhaPGmeZvJ+TNn1yjU32VbOdwKur2Zw/CysVQUwmd/d0sweVw== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 2B9182EB6; Thu, 15 Jul 2021 16:59:37 +0000 (UTC) Date: Thu, 15 Jul 2021 16:59:37 +0000 From: Alexey Dokuchaev To: Guido Falsi Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: dc9bf7d64926 - main - net/asterisk*: Add aarch64 support Message-ID: References: <202107141033.16EAX60T044972@gitrepo.freebsd.org> <81bc6b76-7b74-9990-d7dc-54ca14b0ee4f@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <81bc6b76-7b74-9990-d7dc-54ca14b0ee4f@FreeBSD.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1626368377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q9uSzNXxIXhI4u9kKN2bUOwXoPmyw1xuF7LF7bAaskA=; b=rvk/GptuGVp4ap7UOdELFMdE3HTdm3bAexlyhv35M9LkCT9l6xF6qZ2Zc6+ucuyEfLZ3p8 U4Azmd5Ad+uAqW3adJ3W7rHm7J4AhUpT5zJ17l2GUmDSsgKUb3dubBzO4Uf6RG3tBWr/cy c+pEZkyg/Qy6t9yHnbuSM1rmshFKa8Cj0rmrkevFvxcHfwZ73jCAq1L676BeU9Dtgl4FO9 6bskQiyrntr8+3cqQyfRI5TRE7MOUEecj+cJODZJq86K/Ua98xh6Aj1XhVx73GyGkvWWGP heF9xp3gm42yacG49+JxFPL4mfMHDA1PeEZ90ugxZ0KiH5ZumgYi6fctBWE0Fg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1626368377; a=rsa-sha256; cv=none; b=nLhwEObQ3IuPDhXQuoJln7E3NhSvx9sRoO7IzZiMFzHDHaaQ7yUZtiJaDfEq5UC0R961NM vfz3rgosCAjFV1hBIcBfUlfW0l3f3K38A3AlsuIy6ecUZDZZvBEvdhEMKkettFQD9zgdsP v7b5hbXRP+XOd+OklsZQJ6Qkin6JbqGqgJhBhCDlf4YgAx5ZpPeivsj9KT7Tm93987UPWf SoPDJofjWh1kEekTsFQqaVDt4eLu4cMzdKAFvd3n7zw5vqG1kBUPGYyzYrF7ALnqJmNqBO GVKAg9r/9CZhB6t1VsRbDy5PTRRk4dYt4RCM2uOv4nNB7SkZpSfxhNLgkW1nlw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jul 2021 16:59:37 -0000 On Thu, Jul 15, 2021 at 04:38:53PM +0200, Guido Falsi wrote: > On 15/07/21 04:06, Alexey Dokuchaev wrote: > > ... > > I think ONLY_FOR_ARCHS here clearly outlived its purpose and can just > > be removed. It arguably misses MIPS, but we aren't promising much for > > that tier anyways, and this harness just gets in the way of those who > > know that they're doing. After all, there shouldn't be anything > > inherently architecture-specific about the telephony toolkit, but even > > if there is, individual BROKEN_$arch would be more appropriate. > > The fact that mips is not included is exactly the reason I did not > remove ONLY_FOR_ARCHS. > > If what you say is the general consensus I'll be quite happy to get rid > of it. You'd likely not get general consensus as most people don't care. :-) > I guess this compiler mix situation is not an issue anymore. Right. I think it's generally bad idea to prematurely restrict software to certain arches unless it's clearly arch-specific (e.g. comes only in binary precompiled form or uses asm code). New arches appear frequently (e.g. powerpc64le, riscv64) and some go away as well (ia64, sparc64), it just does not look feasible to maintain those ONLY_FOR_ARCHS lists so they'd always reflect the reality. Even if one's port does break on MIPS, one should get a notice from the build cluster and either fix it, or mark is as BROKEN_$arch, rather than keep ONLY_FOR_ARCHS which would only get amended, causing needless repo churn, upon every next time someone discovers that it builds and works on their architecture of interest. ./danfe