From owner-svn-src-all@FreeBSD.ORG Sat Feb 14 15:17:46 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BD0EE3C3 for ; Sat, 14 Feb 2015 15:17:46 +0000 (UTC) Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 462A3BD7 for ; Sat, 14 Feb 2015 15:17:46 +0000 (UTC) Received: by mail-wi0-f180.google.com with SMTP id h11so18048610wiw.1 for ; Sat, 14 Feb 2015 07:17:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=fByIv+lLXfVOk77sKYYRxYbOFRT14cV4Sb5K0D82J9A=; b=Kc2goij/Do2wgUhgrZVA6/UNg/OX9Y8QLoU6HPvmQzwjbySFVuoyYpc8FFS/cDsxWY xkN1fUDXB1qfB9yF2NM+g4iLA2kvM3bBMbDAq4GN3TD96Kp5y3X6ROfVbnUJtdgXbgLh IqvOISICuEXLCFJNrsy5cCDlZb6sNG3J5ZCRm3tgaA7sXSBdui56wp6kQ0toOrxvrbPg soiuHE0LI2P13fQIyTDANmxdL1+XZ7bCU1Dxk38oCeyPryAcgDpmWXrw/6w9bCxP/2nA VrD8fsKGk+dVYHDueXdrerkQrAKTfejOSF4ApDKr80aQ4NJ+Jvqh4vOB8YRmK0HD2f6c WD3w== X-Gm-Message-State: ALoCoQl+2eNGpBMztFk0Nhq7TxPM13z9+evaj93pUI2cUI2oyu0w15sNjRJA8IoILuRnrY49tC88 X-Received: by 10.194.192.4 with SMTP id hc4mr30545318wjc.59.1423927058746; Sat, 14 Feb 2015 07:17:38 -0800 (PST) Received: from [10.10.1.68] (82-69-141-170.dsl.in-addr.zen.co.uk. [82.69.141.170]) by mx.google.com with ESMTPSA id fo15sm11430605wic.19.2015.02.14.07.17.37 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Feb 2015 07:17:37 -0800 (PST) From: Steven Hartland X-Google-Original-From: Steven Hartland Message-ID: <54DF6709.6030204@freebsd.org> Date: Sat, 14 Feb 2015 15:17:29 +0000 User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Bryan Drewery , phabric-admin@FreeBSD.org Subject: Re: Phabricator + 'Reviewed by' [was Re: svn commit: r278472 - in head/sys: netinet netinet6] References: <201502091928.t19JSC5P066293@svn.freebsd.org> <38B8D2D0-862A-4DF5-9479-8EC234CF830B@FreeBSD.org> <54DE8F32.2090500@FreeBSD.org> In-Reply-To: <54DE8F32.2090500@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, Randall Stewart , svn-src-all@freebsd.org, "Bjoern A. Zeeb" , src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Feb 2015 15:17:46 -0000 On 13/02/2015 23:56, Bryan Drewery wrote: > On 2/9/2015 3:45 PM, Bjoern A. Zeeb wrote: >>> Commented upon by hiren and sbruno >>> See Phabricator D1777 for more details. >>> >>> Commented upon by hiren and sbruno >>> Reviewed by: adrian, jhb and bz >> I have not reviewed this; as a matter of fact you are aware that I still wanted to do that. >> > Something about Phabricator is not jiving with our commit terminology. > This has happened before as well with other commits. I'm sure everyone > is good-intentioned as well. > > There's not 1 person on D1777 who has 'accepted' it. That is what > warrants a 'Reviewed by' to me. > > It's clear to me, but seems unclear to others. I really think the > reviewer list needs to be split up. Rather than using icons, use > separate lists. Reviewers requested: accepted: commented: changes > requested:. I don't think it needs to be split up, that feels unnecessary, if someone hasn't accepted it then they haven't review it period IMO.