From owner-freebsd-ports@freebsd.org Fri May 6 00:19:08 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3D56DB2FB2E for ; Fri, 6 May 2016 00:19:08 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from gw.catspoiler.org (unknown [IPv6:2602:304:b010:ef20::f2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gw.catspoiler.org", Issuer "gw.catspoiler.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 1CD8E1C70 for ; Fri, 6 May 2016 00:19:08 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.15.2/8.15.2) with ESMTP id u460Isuj055739; Thu, 5 May 2016 17:18:58 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Message-Id: <201605060018.u460Isuj055739@gw.catspoiler.org> Date: Thu, 5 May 2016 17:18:54 -0700 (PDT) From: Don Lewis Subject: Re: PRs ready for commit To: rkoberman@gmail.com cc: lists@opsec.eu, freebsd-ports@freebsd.org, bradleythughes@fastmail.fm In-Reply-To: MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2016 00:19:08 -0000 On 5 May, Kevin Oberman wrote: > On Thu, May 5, 2016 at 2:16 PM, Don Lewis wrote: > >> On 5 May, Kurt Jaeger wrote: >> > Hi! >> > >> > One thing: There are issues with buildlogs attached to PR due >> > to them blowing up the database of bugzilla. If all is fine, >> > it's OK to just list the architectures tested. Second best >> > is putting broken buildlogs on some external site and put the link >> > in the PR. Third is adding broken buildlogs as attachment 8-} >> > >> > Yes, I know, disk space is infinite, but this is real life 8-) >> >> For broken builds, I prefer to just include the part of the build log >> showing the error in the comment. If someone thinks that there is still >> some info necessary for debug that is missing, I can extract it from the >> log and add it as another comment. That way the info is easy to access >> and permanently part of the PR. >> >> _______________________________________________ >> freebsd-ports@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-ports >> To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org" >> > > I suggest that it should be the end of the build log with the build done > with "MAKE_JOBS_UNSAFE" defined so the error is likely to actually be at > the end of the log. That's generally the easiest way. If it is a parallel build, just attaching the tail of the log file is generally pretty useless. Sometimes I'll rerun a failing parallel build single threaded to so that the point of failure is close to the end where I can easily grab it. That doesn't work if the problem is actually caused by the parallel build (and the build is clean when done single threaded). In that case I search backwards from the end to find exactly what caused the failure.