Date: Thu, 14 Jul 2005 08:36:08 -0400 From: Andrew Gallatin <gallatin@cs.duke.edu> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_xl.c Message-ID: <20050714083608.A21239@grasshopper.cs.duke.edu> In-Reply-To: <200507131406.j6DE6DLv066313@repoman.freebsd.org>; from glebius@FreeBSD.org on Wed, Jul 13, 2005 at 02:06:13PM %2B0000 References: <200507131406.j6DE6DLv066313@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Gleb Smirnoff [glebius@FreeBSD.org] wrote: > glebius 2005-07-13 14:06:13 UTC > > FreeBSD src repository > > Modified files: > sys/pci if_xl.c > Log: > NET_LOCK_GIANT() when entering network code. > Do other drivers do this? It looks like at least em, fxp and my out-of-tree commercial driver have the same "bug". I would argue that any fiddling with Giant should go into the various if_input routines instead. Drew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050714083608.A21239>