From owner-cvs-src@FreeBSD.ORG Tue Sep 23 22:18:49 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C73261065671; Tue, 23 Sep 2008 22:18:49 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85]) by mx1.freebsd.org (Postfix) with ESMTP id A44E48FC19; Tue, 23 Sep 2008 22:18:49 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1]) by dragon.nuxi.org (8.14.2/8.14.2) with ESMTP id m8NMIn6F006546; Tue, 23 Sep 2008 15:18:49 -0700 (PDT) (envelope-from obrien@dragon.nuxi.org) Received: (from obrien@localhost) by dragon.nuxi.org (8.14.2/8.14.2/Submit) id m8NMIm50006545; Tue, 23 Sep 2008 15:18:48 -0700 (PDT) (envelope-from obrien) Date: Tue, 23 Sep 2008 15:18:48 -0700 From: "David O'Brien" To: "Bjoern A. Zeeb" Message-ID: <20080923221848.GA6386@dragon.NUXI.org> References: <200809231446.m8NEkQev007507@repoman.freebsd.org> <20080923171859.S65801@maildrop.int.zabbadoz.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080923171859.S65801@maildrop.int.zabbadoz.net> X-Operating-System: FreeBSD 8.0-CURRENT User-Agent: Mutt/1.5.16 (2007-06-09) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files src/sys/fs/tmpfs tmpfs.h tmpfs_subr.c tmpfs_vnops.c src/sys/i386/i386 bios.c src/sys/ia64/ia64 efi.c sal.c src/sys/libkern memcmp.c src/sys/mips/mips support.S src/sys/sys libkern.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Sep 2008 22:18:49 -0000 On Tue, Sep 23, 2008 at 05:21:04PM +0000, Bjoern A. Zeeb wrote: > Below you have changed a few places back to actually use bcmp instead > of memcmp. > I see lots of or more places in our kernel using memcmp. Are you > saying that they all need to be memcmp instead of bcmp and had been > unproper results so far I am not saying the memcmp's I did not touch have to be memcmp and cannot be changed to bcmp(). > or is the files down just a random collection > of memcmp->bcmp changes introduced with the same commit? They are not random, but the set of memcmp uses in $ARCH/$ARCH that did not depend on the memcmp behavior, and are pure BSD files and thus bcmp() usage should not upset anyone. I did not touch drivers that may be trying to share code or otherwise have minimal changes. -- -- David (obrien@FreeBSD.org)