Date: Sat, 30 Nov 2019 05:58:40 +0100 From: Tobias Kortkamp <tobik@freebsd.org> To: Jan Beich <jbeich@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r518693 - head/games/aquaria Message-ID: <20191130045840.GA43413@urd.tobik.me> In-Reply-To: <201911300213.xAU2DJOo019231@repo.freebsd.org> References: <201911300213.xAU2DJOo019231@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--tKW2IUtsqtDRztdT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 30, 2019 at 02:13:19AM +0000, Jan Beich wrote: > Author: jbeich > Date: Sat Nov 30 02:13:18 2019 > New Revision: 518693 > URL: https://svnweb.freebsd.org/changeset/ports/518693 >=20 > Log: > games/aquaria: partially revert r518662 > =20 > aarch64 and armv7 weren't affected. amd64 was fixed since LLD 7 but > i386 still fails. Losing LTO (and CFI) support is not worth just for > consistency with an architecture that may become Tier2 in future. > =20 > ld: error: cannot preempt symbol: alGetSourcei > >>> defined in /usr/local/lib/libopenal.so > >>> referenced by FmodOpenALBridge.cpp > >>> CMakeFiles/aquaria.dir/BBGE/FmodOpenALBridge.cpp.o:(O= ggDecoder::decode_loop(OggDecoder*)) > =20 > Pointy hat to: jbeich (bug 242307 comment 11) What do you think about setting=20 LDFLAGS_i386=3D -Wl,-z,notext here instead (also in openal-soft)? It unbreaks the build of either one with lld on 12.1 i386. >=20 > Modified: > head/games/aquaria/Makefile (contents, props changed) >=20 > Modified: head/games/aquaria/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/games/aquaria/Makefile Sat Nov 30 02:10:21 2019 (r518692) > +++ head/games/aquaria/Makefile Sat Nov 30 02:13:18 2019 (r518693) > @@ -41,8 +41,7 @@ SUB_FILES=3D pkg-message > PLIST_FILES=3D bin/aquaria > PORTDATA=3D * > =20 > -# XXX Drop after FreeBSD 12.0 EOL > -.if exists(/usr/lib/clang/6.0.1) > +.if ${MACHINE_ARCH} =3D=3D i386 || exists(/usr/lib/clang/6.0.1) > LLD_UNSAFE=3D yes # XXX ports/219089 > .endif > =20 --tKW2IUtsqtDRztdT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAl3h9v1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2E9Dwf+PJvKvJbKNpNhAr6vyboG56cMtApFzECe4eocmy1tpxxNTnU16YvhvFhA JnIvc2dqaPCpgdPGV0EMi7XknYvWwGfxJEJLlbfxGsGwvfhKCQ5H+D8+y/5bB0+u ywG3BiHIfGO1o4D1u/Cd7x/8LNuppq/0/5L0prNx4fZisWRq+uj323pe5eFM5NNd Vu7t74ADTCEsMFFaSF6DsvToLKfn5fgiTNjCxFDNf2IzglNX60pFq10/OSlxYoVw X6Fu8MhFTcy4GkZdVaod4D1hAPggM03PDkDxF4QPypyG5EZNh1GLAr16mV/AGEzL w/X6khDv4eIbh3TGJGaf8x5hpo1IOQ== =2O0W -----END PGP SIGNATURE----- --tKW2IUtsqtDRztdT--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191130045840.GA43413>