Date: Thu, 24 Mar 2005 01:48:44 +0900 From: Hajimu UMEMOTO <ume@freebsd.org> To: Sam Leffler <sam@errno.com> Cc: freebsd-stable@freebsd.org Subject: Re: RELENG_5 and FAST_IPSEC limits Message-ID: <ygezmwufgur.wl%ume@mahoroba.org> In-Reply-To: <4239B796.80303@errno.com> References: <6.2.1.2.0.20050315112131.054b56f8@64.7.153.2> <4237523B.7090005@errno.com> <ygek6o7inb5.wl%ume@mahoroba.org> <4238782A.7010606@errno.com> <ygeis3rbcu7.wl%ume@mahoroba.org> <4239B796.80303@errno.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
>>>>> On Thu, 17 Mar 2005 09:00:06 -0800
>>>>> Sam Leffler <sam@errno.com> said:
sam> Possibly; I can't tell from the patch if locks are held across calls
sam> they should not be. I also worry about the effect of holding the various
sam> locks for an extended period of time (will it impact packet processing?)
Since key_setdump() which is substantial function of KEYCTL_DUMPSA
sysctl does in much the same way as key_dump(), I added locking in a
similar manner. So, I believe period of time for holding the locks is
differ little from key_dump(). However, sysctl required calling
key_setdump() twice; 1st is for getting data size and 2nd is for
actuall query.
sam> Are you suggesting KAME code can/will change to eliminate the use of
sam> PF_KEY sockets to query the SA db state?
It seems that SADB_DUMP is useless on large system, and we need an
alternative for it. Once we introduce an alternative, we don't need
SADB_DUMP within our tree.
However, SADB_DUMP is defined in RFC 2367 and deployed. So, we should
not eliminate it for now. I hope it should be deprecated in the
future.
The reason I'm going to bring KEYCTL_DUMPSA sysctl into FreeBSD is
that there is implementation and Racoon supports it as well. NetBSD
has KEYCTL_DUMPSA already, and OpenBSD added similar sysctl recently.
I wonder if KEYCTL_DUMPSA sysctl is good for alternative. We need to
call sysctl twice for variable length data such as SA dump. It may
become overhead. Further, data size is unassured to be same between
these two sysctl call. If data grows, 2nd sysctl call will fail.
In anyway, it solves a limitation of SADB_DUMP.
Sincerely,
--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume@mahoroba.org ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ygezmwufgur.wl%ume>