From owner-svn-src-head@freebsd.org Mon Jun 3 16:03:57 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3736915B5BAF for ; Mon, 3 Jun 2019 16:03:57 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C0D578824E for ; Mon, 3 Jun 2019 16:03:56 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: by mail-io1-f43.google.com with SMTP id m24so1363996ioo.2 for ; Mon, 03 Jun 2019 09:03:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kxj31LewPvbp6zwgtdAYYqM15GbbsTRrLi3fReZbnb0=; b=gkbnQtCZSDipZBvrT3UWsMvDcRISjkvB3ySfXqQJ2AK/DzXphxRId0P9C1iqPeGMT1 JHgGcwEyyyrC6OqjZd6yNKrY5ReJuWfj5v55U8h0FcheE+zWakUv8PMByymg/Ugp7cfC rB8vwn4pLKXcHi3jKUYWxMC1ND/E8JkNHTnquMQDnSmEqM8zDNDeVnBtt0kSWsOPEOQV fV2wNanHQYzBxdE8mpch47PyLTZijasC4lykEVFslNeibeDuAB354aQNnPHwSiIjFhS5 EEnQ59cZ9w745uLadwSvEYHJISNXq0mVrjQFXDrRCnr/8kmUG8ed6cdy8oGaKJDL3f5u hOuw== X-Gm-Message-State: APjAAAV3s8i8rq2H1eduWd220kCnaaqoQ3xVkCa4X0bdsrQ2TngnFDg6 /JzN2Cmg70m1B31pEYvJsn2BHh71GbCdjYYJLoF/IA== X-Google-Smtp-Source: APXvYqytdRQQWYCja+z4p/mFyf8Qkqw22TO7Laa8ZCQgXgStmIaMMmp+GP/BzapLrq0cD/WlHh/Gi995nmTxKNG0B5Q= X-Received: by 2002:a5d:9b04:: with SMTP id y4mr10830441ion.195.1559577413178; Mon, 03 Jun 2019 08:56:53 -0700 (PDT) MIME-Version: 1.0 References: <201906022338.x52NcJV9070782@repo.freebsd.org> <99965642-23AF-492C-9D3E-19AE069AB323@gmail.com> In-Reply-To: <99965642-23AF-492C-9D3E-19AE069AB323@gmail.com> From: Maxim Sobolev Date: Mon, 3 Jun 2019 08:56:41 -0700 Message-ID: Subject: Re: svn commit: r348521 - in head: . etc sys/conf sys/modules usr.bin/login usr.sbin/services_mkdb To: Enji Cooper Cc: src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: C0D578824E X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.972,0] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2019 16:03:57 -0000 On Mon, Jun 3, 2019 at 7:28 AM Enji Cooper wrote: > Hi Maxim, > > > > Modified: head/Makefile.inc1 > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > > --- head/Makefile.inc1 Sun Jun 2 22:27:26 2019 (r348520) > > +++ head/Makefile.inc1 Sun Jun 2 23:38:19 2019 (r348521) > > @@ -887,8 +887,8 @@ MTREEFLAGS+=3D -W > > INSTALLFLAGS+=3D -h sha256 > > .endif > > .if defined(DB_FROM_SRC) || defined(NO_ROOT) > > -IMAKE_INSTALL=3D INSTALL=3D"install ${INSTALLFLAGS}" > > -IMAKE_MTREE=3D MTREE_CMD=3D"mtree ${MTREEFLAGS}" > > +IMAKE_INSTALL=3D INSTALL=3D"${INSTALL} ${INSTALLFLAGS}" > > +IMAKE_MTREE=3D MTREE_CMD=3D"${MTREE_CMD} ${MTREEFLAGS}" > > .endif > > Please back out this part of the change as it is unnecessary and adds > a dependency on sys.mk=E2=80=99s definitions. $PATH should contain, i.e.,= be > populated, with these tools when running make installworld. This is part = of > the logic behind how $ITOOLS, etc, works. > Thank you very much for your work and the rest of the change though! > Thanks Enji, for a clarification, will do. I still cannot understand why can't we have those tools being re-defined with top-level make environment? What I am striving at is being able to do say, make INSTALL=3D"abcd" installworld. Yes, I understand I can call "abcd" "install" (or make a symlink to it) and put it into PATH, but there are at least one issue here, namely what if I need to pass some distinct argument to abcd based on usage scenario. E.g. make INSTALL=3D"abcd foo" distributiuon. In your case I shou= ld be resorting to setting up some global environment variable and hope it won't get erased somewhere in the call chain, but that's bit "how you doing" IMHO. My approach makes certain things so much easier by cutting those un-neded steps. At any rate thank for a feedback and some background info, I will do more work on this. I was thinking more in terms of having some sort of bsd.bootools.mk where this can be defined in a centralized manner. -Max