Date: Tue, 9 Jun 1998 00:32:19 +0100 (BST) From: Doug Rabson <dfr@nlsystems.com> To: Sren Schmidt <sos@FreeBSD.ORG> Cc: "Jordan K. Hubbard" <jkh@time.cdrom.com>, bde@zeta.org.au, cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/isa/snd ad1848.c sb_dsp.c sound.c Message-ID: <Pine.BSF.3.95q.980609002138.351C-100000@herring.nlsystems.com> In-Reply-To: <199806081140.NAA03454@sos.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 8 Jun 1998, Sren Schmidt wrote: > the devfs stuff was broken > the ELF activator was broken > the sound system was broken > the wd driver was broken > the wst driver was broken > DDB was broken. Elf and DDB are fair comment. I was under the distinct impression that I tested Elf and Linux compat but I think I made a mistake and booted the wrong kernel. Such is life. DEVFS and SLICE for whatever reason are not enabled in LINT. Perhaps I was wrong in thinking that LINT contained all reasonable combinations of drivers and options. If there are problems with configurations that are not compatible with LINT, then we need more test configurations. I believe that I have fixed any breakage in a timely fashion. IMHO with a commit like this some fallout is inevitable. > > Need I continue ?? > > > 4. If building LINT is no longer a sufficient test, we should determine > > what *is* a sufficient test before we start flaming people. > > It has NEVER been sufficient to build LINT :), and it probably never will > be, there are too much interference between different drivers etc for > that to work. Find & grep is some of your helpers here, and so would a large > regressiontest framework be, but we don't have that. So one should at > least grep for the matter (here a simple grep for ioctl would have > done nicely), or have the code run through a couple of others as they > will most often have different setups and will probably spot some > of the offending bugs. > > As usual we all make mistakes (and I've done my fair share), but generic > changes like these should be tested & reviewed by at least a couple > of others with different setups. As I recall I mailed core about this change and only Bruce was kind enough to show any interest. Certainly no-one asked to review the diffs. I have no interest in a flame war on this and I have my own pointy hat to wear for the next couple of days so lets just leave it at that ok? -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 951 1891 Fax: +44 181 381 1039 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.95q.980609002138.351C-100000>