From owner-cvs-all@FreeBSD.ORG Mon Feb 18 14:40:23 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8154E16A474; Mon, 18 Feb 2008 14:40:23 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id AE79A13C4FF; Mon, 18 Feb 2008 14:40:22 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id m1IEeH7W067140; Mon, 18 Feb 2008 17:40:17 +0300 (MSK) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id m1IEeH6J067139; Mon, 18 Feb 2008 17:40:17 +0300 (MSK) (envelope-from yar) Date: Mon, 18 Feb 2008 17:40:16 +0300 From: Yar Tikhiy To: Craig Rodrigues Message-ID: <20080218144016.GK30694@comp.chem.msu.su> References: <200802181024.m1IAOmoF089632@repoman.freebsd.org> <20080218103736.GA79284@crodrigues.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080218103736.GA79284@crodrigues.org> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/mount_nfs mount_nfs.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Feb 2008 14:40:23 -0000 On Mon, Feb 18, 2008 at 10:37:36AM +0000, Craig Rodrigues wrote: > On Mon, Feb 18, 2008 at 10:24:48AM +0000, Yar Tikhiy wrote: > > The real solution would be to bring the whole nmount(2) > > framework, including FS drivers and userland tools, into > > a consistent state at last; but things should work in the > > meantime, too. > > When I read comments like this, I have the feeling > that you are doing drive-by-commits to areas where you do > not understand the full implications of what you are doing. I'll pray for your understanding to be better than mine. > Can you slow down on your commits to the mount code, and try > to post more of your patches to mailing lists so other people > can review them and try them out? You've indicated to me > that you don't have time to fully test out and implement the > necessary changes to fix all the file systems and userland code > in FreeBSD related to mounting file systems. I have no more commits pending in my queue. > While I appreciate your efforts to deal with PR's and fix things, > the mount code is a tangled web, and it is very easy to introduce > subtle errors in unrelated areas by committing what appear > to be "obvious fixes". This has happened to a few people (including > me) in the past. Indeed, all our sins are recorded in the CVS history. ;-) -- Yar