From owner-freebsd-current@FreeBSD.ORG Tue Jan 1 03:13:59 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6EF59560 for ; Tue, 1 Jan 2013 03:13:59 +0000 (UTC) (envelope-from kaduk@mit.edu) Received: from dmz-mailsec-scanner-3.mit.edu (DMZ-MAILSEC-SCANNER-3.MIT.EDU [18.9.25.14]) by mx1.freebsd.org (Postfix) with ESMTP id 1621E8FC08 for ; Tue, 1 Jan 2013 03:13:58 +0000 (UTC) X-AuditID: 1209190e-b7fa16d000001402-38-50e25344e693 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP id C6.92.05122.44352E05; Mon, 31 Dec 2012 22:08:52 -0500 (EST) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id r0138qaa007761; Mon, 31 Dec 2012 22:08:52 -0500 Received: from multics.mit.edu (SYSTEM-LOW-SIPB.MIT.EDU [18.187.2.37]) (authenticated bits=56) (User authenticated as kaduk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id r0138nPQ011676 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 31 Dec 2012 22:08:51 -0500 (EST) Received: (from kaduk@localhost) by multics.mit.edu (8.12.9.20060308) id r0138nAF023828; Mon, 31 Dec 2012 22:08:49 -0500 (EST) Date: Mon, 31 Dec 2012 22:08:49 -0500 (EST) From: Benjamin Kaduk To: Garrett Cooper Subject: Re: svn commit: r244604 - head/usr.sbin/gssd In-Reply-To: Message-ID: References: <1905046872.1604317.1356954929867.JavaMail.root@erie.cs.uoguelph.ca> User-Agent: Alpine 1.10 (GSO 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKIsWRmVeSWpSXmKPExsUixG6nousS/CjAYM9KMYs5bz4wWTxcdo3J Yv33ZYwOzB4zPs1n8dg56y67x+/Ne5kCmKO4bFJSczLLUov07RK4MvoXOhW8Ya14cegsYwPj WZYuRk4OCQETif+f57NB2GISF+6tB7OFBPYxSpy7Id7FyAVkb2CUeHh6IlTiBJPExa9qEIkG RokPcxexgiRYBLQlHu5qYwex2QRUJGa+2QjWICKgLnHpwBagOAcHs4CLxOaFlSBhYQFTiQ/t q8FKOAUCJdbM38gIYvMKOEo0TfvKCDH/FqPE0Y6rTCAJUQEdidX7p7BAFAlKnJz5BMxmFrCU OPfnOtsERsFZSFKzkKQWMDKtYpRNya3SzU3MzClOTdYtTk7My0st0jXWy80s0UtNKd3ECApd Tkm+HYxfDyodYhTgYFTi4U14+jBAiDWxrLgy9xCjJAeTkijv0qBHAUJ8SfkplRmJxRnxRaU5 qcWHGCU4mJVEeE/dAyrnTUmsrEotyodJSXOwKInzXkm56S8kkJ5YkpqdmlqQWgSTleHgUJLg LQMZKliUmp5akZaZU4KQZuLgBBnOAzS8E6SGt7ggMbc4Mx0if4pRUUqctw0kIQCSyCjNg+uF pZZXjOJArwjzdoNU8QDTElz3K6DBTECDtRgegAwuSURISTUwTlRYljf/+KaHBsbFt76VbLto lZyzUuB08eSOHCPjiU3/qr0KLqxgr44TsK2dvvqL+cE9h87YmrqedeLxmiYgJBgcN0U9eMK/ lV+fNhyUfhe6XJ7xsdKzUxN4Ll89tG5RYcKS9r9vLY89LmndfGSTTk2y4BWT/UvmtzgJ1aoV tl0MvO6SqPK0UImlOCPRUIu5qDgRAPO6oGIIAwAA Cc: Rick Macklem , freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jan 2013 03:13:59 -0000 On Mon, 31 Dec 2012, Garrett Cooper wrote: > On Mon, Dec 31, 2012 at 3:55 AM, Rick Macklem wrote: > > ... > >> WITHOUT_KERBEROS is used other places, like telnetd. Were you aware of that? >> (I just thought it would keep it consistent, but if you think it is better >> to use a different name, I don't care.) > > Ah, no. I wasn't aware of that :). Given that something else has been > standardized around the tree, I agree that your approach of using > WITHOUT_KERBEROS is ok. I wasn't keen on the name just because it > could have simplified the code using a positive instead of a negative > predicate in the #ifdef. src.conf(5) is (well, should be) authoritative for WITH_ and WITHOUT_ flags. -Ben