From owner-freebsd-current@freebsd.org Tue Jun 23 15:12:50 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 88815330007 for ; Tue, 23 Jun 2020 15:12:50 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660066.outbound.protection.outlook.com [40.107.66.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49rqXK47hWz4g00; Tue, 23 Jun 2020 15:12:49 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BcOwXBVl8e6GHwDPfHEN/8fgH+pjE90eJBwq6OJwXRN0yeLYSu995zaxHfrar+lzzihS1Ji7kBHqzfZpc76eOpwzVjIMHd+/TlBzyuoIoxM7/fqlSNWTskL8M7+K+NameRecaVH7jGlyH1pR1bSBGMFyrVYGwxHpDsl+pO8dOox1ZPydOOh33u5j4zaUCr0FaSRIJzyMVH1iTRN1IagUwMjD9SHN/fgMlfmAAuWcCsvh/0ri3+GoC6BUN7s2YMxYyW3/Rz+URis/mkQmbjOaShaHDZKIw1hRoXupR9yu0yAcYdPoUpBpHlXA59Onk2ASSAN6ru7XMlUSiExXNauZIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4IEKBX36kPC5GI4G8czanT9oz8M0PcgfKewWBjm+Vjg=; b=VGwp5HR66Jcirzj6mdu7BDEpYsKndZcKb4s4T8D7gaLLkWHHq1ArdkepOpnKeQTxhkh7uDBoo1vokC9ETqnP71p8EU+KNENsUM2Rp8xzWmfBvpykGY0TGABCDJNEXFGE6sib7NBHHecBipf2XkfxtQLa+RdVKXqil0WpDZ7kPesL/wC2okfcyl/j4NolDGKzVIBZ0zmGF95FUsKsO5pjZw7d3gr3A4U2ts8gxKFzj2mdET2Exi1vfTtRXIcKGlqdkeWC7JICzMvwYsBXPermgG0IA37riK5wLWG9NmWh5WtsFCbSz2C7hLnSjf/czMjyOSHcYzou7ABybzxP8RLycw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uoguelph.ca; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4IEKBX36kPC5GI4G8czanT9oz8M0PcgfKewWBjm+Vjg=; b=KVZdt8TyKWkzffwfj1Fe6NhPfRFQjzsnfStBMCMn9lIHu/1PWslML69KOKQmUkWhaCLYmTJk3tiF/rkctMp1KFY7X5PbaZ7OMDs0fvMKVJE+4nB5DFkEQ/5zvlc9fVQHMnexUC/3NwWPTY/bi4T1OpOb6xQQeK655jHbc3iQHw9BIq7oqwJyf8cyvGFJKB3jY9Y6SxajYicmC6iWFgAj4K8JVLajLjoDV2ESJivmtDFISpSk6rGzosYf2zPmqK3WfmBpZUHhHTe1/nWVV49gy9a3jwNJTskMj6wPrACUU5OHrS++RZCcRnKnCyJ/PhYbdAZT9vMcLYTq4O3YbMtDrQ== Received: from QB1PR01MB3364.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:38::14) by QB1PR01MB3250.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:32::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.21; Tue, 23 Jun 2020 15:12:46 +0000 Received: from QB1PR01MB3364.CANPRD01.PROD.OUTLOOK.COM ([fe80::60f3:4ca2:8a4a:1e91]) by QB1PR01MB3364.CANPRD01.PROD.OUTLOOK.COM ([fe80::60f3:4ca2:8a4a:1e91%7]) with mapi id 15.20.3109.027; Tue, 23 Jun 2020 15:12:46 +0000 From: Rick Macklem To: Kostya Berger , Freebsd-current CC: Ryan Moeller Subject: Re: openzfs-kmod build error Thread-Topic: openzfs-kmod build error Thread-Index: AQHWSWnv3nyb/Fs3LEao8e4Dfk5JoKjmSsG0 Date: Tue, 23 Jun 2020 15:12:46 +0000 Message-ID: References: <1250230056.4543844.1592922228227.ref@mail.yahoo.com>, <1250230056.4543844.1592922228227@mail.yahoo.com> In-Reply-To: <1250230056.4543844.1592922228227@mail.yahoo.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c9e7277b-ec3b-4669-340d-08d81787e294 x-ms-traffictypediagnostic: QB1PR01MB3250: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 04433051BF x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vQMoFBQF4d1dx6pYYxMobo9cTUcXfvqdI0FBMlK9ahw7P9S5HVCcQg6G+Jc8DVLCfvC8awmU6RMew4R2taeNRWUHQyXWL7qdwyugwlJWK4FGRiOtGZzb6t5/MVXrXMVnXrP5C5Fl8H65iI27FyTLFRToR6OLnCQlFlCpVifc79PLwEYg/hS3mSa0L7DEpgr/ZUL7NnHHIfjRvvJkvmVSAlQju6D2OXPZjEjuiHanVb/UnH2Bj/Tt8intKd0Kd7ZPPVfftqeKWjjH8SETleQ9FSE1rP+wW/zC39U/kejIPdHaRlivEzeo45KVn/88YOn50BNbl00rt5rEEOiSX5IkopIZZ8N6isfNmIA6AQaJP7hwIa23T3svHQ0Zq9LTNln+iAoPI12sO9FICV5iyQ5DMw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:QB1PR01MB3364.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFTY:; SFS:(346002)(396003)(376002)(366004)(136003)(39860400002)(4326008)(52536014)(7696005)(3480700007)(86362001)(2906002)(110136005)(316002)(5660300002)(966005)(186003)(786003)(71200400001)(478600001)(6506007)(33656002)(66476007)(91956017)(66946007)(66446008)(76116006)(8936002)(55016002)(9686003)(8676002)(64756008)(66556008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: HwT15r5tGoFWwulz1n60EF9kPmi+Js+G6cw5qBfNhyNAhoP2GrULyhEM/DJjDrx1LdqS/vECTayrPFC7Q45eec3cZaoRiZHuQE+UQkghWDnsJvl/7OpvHbkUen0Y9yBeSHhffU9xTYEjCQsc4DNFLdQKT815O47yB1W3Sejk7D84YVHMDMgl9/547t4LyR8ckXqOFkTbTWZH0qc573iZ53aAV47HcvvHl4iZuvgIuQjUTyDmbUA5yFfTfC17Lxx8hJoEzeU9MbhBVs9dhL9UPf8vhMcMsvs8u9ni+ffZ0vVpo/kP4nGKVXH9PEShy8HaFpOXX0nLUESaOpq9SWfIgkLegGX0DALleEXbxkVMrhOS2eqDvWUXu6OVwlLwdMtiriUd2gjtpuzrkv5KdUAqZQih1YhBZyENQDcxdAnW98wxcOwcD33xCPzygjjna/+7HJcMxGqZDTV9IjouIR15173f0KnLiqxHxhaxp/x7r2hsCFYqDdr2yRe2ZyMS9ZS1QASL304dBjoRtlbL8rjpPPbOfhqEyAwGXznLFq1aqrM= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: c9e7277b-ec3b-4669-340d-08d81787e294 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2020 15:12:46.1023 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /A91By2Y10FF5AxgyNrFjvQ2QMhcsY2CuZpoBVXGHWe51zsGuWUSXkz/awrEGjesY8pv/Ku1adoKOisE3oOpvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: QB1PR01MB3250 X-Rspamd-Queue-Id: 49rqXK47hWz4g00 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=uoguelph.ca header.s=selector1 header.b=KVZdt8Ty; dmarc=none; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.66.66 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-5.03 / 15.00]; NEURAL_HAM_MEDIUM(-1.01)[-1.015]; R_DKIM_ALLOW(-0.20)[uoguelph.ca:s=selector1]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; NEURAL_HAM_LONG(-0.98)[-0.981]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[uoguelph.ca]; DWL_DNSWL_LOW(-1.00)[uoguelph.ca:dkim]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[uoguelph.ca:+]; NEURAL_HAM_SHORT(-0.54)[-0.538]; RCVD_IN_DNSWL_NONE(0.00)[40.107.66.66:from]; FREEMAIL_TO(0.00)[yahoo.co.uk,freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:8075, ipnet:40.104.0.0/14, country:US]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; RWL_MAILSPIKE_POSSIBLE(0.00)[40.107.66.66:from] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jun 2020 15:12:50 -0000 Kostya Berger wrote:=0A= >CURRENT r362292=0A= >sysutils/openzfs-kmod build aborts with error:...............=0A= >/usr/ports/sysutils/openzfs-kmod/work/zfs->c0eb5c35e/module/os/freebsd/zfs= /zfs_vfsops.c:128:19: error:=0A= > incompatible pointer types initializing 'vfs_checkexp_t *' (aka 'int= (*)(struct=0A= > mount *, struct sockaddr *, unsigned long *, struct ucred **, int *,= int *)') with=0A= > an expression of type 'int (vfs_t *, struct sockaddr *, int *, struc= t ucred **, int=0A= > *, int **)' (aka 'int (struct mount *, struct sockaddr *, int *, str= uct ucred **,=0A= > int *, int **)') [-Werror,-Wincompatible-pointer-types]=0A= > .vfs_checkexp =3D zfs_checkexp,=0A= > ^~~~~~~~~~~~=0A= >/usr/ports/sysutils/openzfs-kmod/work/zfs->c0eb5c35e/module/os/freebsd/zfs= /zfs_vfsops.c:1911:56: error:=0A= > incompatible pointer types passing 'int *' to parameter of type 'uin= t64_t *'=0A= > (aka 'unsigned long *') [-Werror,-Wincompatible-pointer-types]=0A= > return (vfs_stdcheckexp(zfsvfs->z_parent->z_vfs, nam, extflagsp,= =0A= > ^~~~~~~~~=0A= >/usr/src/sys/sys/mount.h:980:17: note: passing argument to parameter here= =0A= >vfs_checkexp_t vfs_stdcheckexp;=0A= > ^=0A= >/usr/ports/sysutils/openzfs-kmod/work/zfs->c0eb5c35e/module/os/freebsd/zfs= /zfs_vfsops.c:1912:32: error:=0A= > incompatible pointer types passing 'int **' to parameter of type 'in= t *';=0A= > dereference with * [-Werror,-Wincompatible-pointer-types]=0A= > credanonp, numsecflavors, secflavors));=0A= > ^~~~~~~~~~=0A= > *=0A= >/usr/src/sys/sys/mount.h:980:17: note: passing argument to parameter here= =0A= >vfs_checkexp_t vfs_stdcheckexp;=0A= > ^=0A= >3 errors generated.=0A= >*** Error code 1=0A= >=0A= >Stop.=0A= Post r362158, the argument types change. Since they are just passed to=0A= vfs_stdcheckexp(), all that needs to be done is changing the types of=0A= the arguments.=0A= =0A= freqlabs@ volunteered to do this upstream, but I don't know if/when=0A= that gets applied to the port?=0A= =0A= If you can fix this, simply replace:=0A= zfs_checkexp(vfs_t *vfsp, struct sockaddr *nam, int *extflagsp,=0A= struct ucred **credanonp, int *numsecflavors, int **secflavors)=0A= =0A= with=0A= =0A= zfs_checkexp(vfs_t *vfsp, struct sockaddr *nam, uint64_t *extflagsp,=0A= struct ucred **credanonp, int *numsecflavors, int *secflavors)=0A= =0A= in the two places it exists in zfs_vfsops.c.=0A= =0A= rick=0A= =0A= =0A= =0A= With kindest regards,=0A= Kostya Berger=0A= =0A= _______________________________________________=0A= freebsd-current@freebsd.org mailing list=0A= https://lists.freebsd.org/mailman/listinfo/freebsd-current=0A= To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"= =0A=