Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 27 Dec 2019 10:07:49 -0800
From:      Steve Kargl <sgk@troutmask.apl.washington.edu>
To:        freebsd-current@freebsd.org
Subject:   Re: [PATCH] primes(6) -- remove unnecessary code
Message-ID:  <20191227180749.GA60730@troutmask.apl.washington.edu>
In-Reply-To: <20191227175458.GA60597@troutmask.apl.washington.edu>
References:  <20191227175458.GA60597@troutmask.apl.washington.edu>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 27, 2019 at 09:55:10AM -0800, Steve Kargl wrote:
> This patch removes an unnecessary check as
> the condition can never occur.
> 
> Index: primes.c
> ===================================================================
> --- primes.c	(revision 355983)
> +++ primes.c	(working copy)
> @@ -129,7 +129,7 @@
>  	switch (argc) {
>  	case 2:
>  		/* Start and stop supplied on the command line. */
> -		if (argv[0][0] == '-' || argv[1][0] == '-')
> +		if (argv[1][0] == '-')
>  			errx(1, "negative numbers aren't permitted.");
>  
>  		errno = 0;

Hmm, I withdraw the patch.  One can get a negative start 
value, but one would need to force that condition via
a subversion via getopt.

-- 
Steve



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191227180749.GA60730>