Date: Wed, 9 Jul 2008 21:39:12 -0400 From: John Baldwin <jhb@FreeBSD.org> To: Rui Paulo <rpaulo@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/k8temp k8temp.c Message-ID: <200807092139.12985.jhb@freebsd.org> In-Reply-To: <200807052319.m65NJgp8097891@repoman.freebsd.org> References: <200807052319.m65NJgp8097891@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday 05 July 2008 07:19:37 pm Rui Paulo wrote: > rpaulo 2008-07-05 23:19:37 UTC > > FreeBSD src repository > > Modified files: > sys/dev/k8temp k8temp.c > Log: > SVN rev 180312 on 2008-07-05 23:19:37Z by rpaulo > > Use config_intrhook API to create the dev.cpu.N.temperature sysctl node. > Our hook creates the sysctl node before root is mounted, but after cpu > is probed. It seems that k8temp can be loaded before the cpu module and, > in those cases, dev.cpu.0.temperature was not created. Err, why not rework this so that you have a k8tempctl0 device that attaches to the PCI part (or just use it directly like ichss0 does) and then have a per-CPU k8temp0 device? This would be a cleaner solution w/o needing an intrhook (and would also work if someone disables ACPI). -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200807092139.12985.jhb>