Date: Tue, 12 Jul 2011 23:29:42 -0500 From: Stephen Montgomery-Smith <stephen@missouri.edu> To: Doug Barton <dougb@FreeBSD.org> Cc: Pav Lucistnik <pav@FreeBSD.org>, Stephen Montgomery-Smith <stephen@FreeBSD.org>, Jung-uk Kim <jkim@FreeBSD.org>, "freebsd-ports@FreeBSD.org" <freebsd-ports@FreeBSD.org> Subject: Re: [RFC] A trivial change for DESKTOP_ENTRIES Message-ID: <4E1D1F36.5030604@missouri.edu> In-Reply-To: <4E1D1C70.4050505@FreeBSD.org> References: <201107121826.00020.jkim@FreeBSD.org> <4E1D1A21.601@missouri.edu> <4E1D1C70.4050505@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07/12/2011 11:17 PM, Doug Barton wrote: > On 07/12/2011 21:08, Stephen Montgomery-Smith wrote: >> Thinking more about it, it seems to me that instead of silently deleting >> the disallowed characters in the filename, that the port should declare >> itself broken if there are disallowed characters. That way, this >> particular error would have been caught far more easily. > > I was thinking along similar lines. My concern would be that if the > change to allow - and _ is done silently that it will break plists. > > I don't see how it can break plists - a few lines later (around line 6440), bsd.port.mk dynamically generates the entries for plist from $filename.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E1D1F36.5030604>