From owner-freebsd-acpi@FreeBSD.ORG Wed Jun 8 19:01:37 2005 Return-Path: X-Original-To: freebsd-acpi@freebsd.org Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D7D0E16A41C; Wed, 8 Jun 2005 19:01:37 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9A1BF43D49; Wed, 8 Jun 2005 19:01:37 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.34] (adsl-67-119-74-222.dsl.sntc01.pacbell.net [67.119.74.222]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j58J1ZZ6001621 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 8 Jun 2005 12:01:36 -0700 Message-ID: <42A73FEE.4090202@root.org> Date: Wed, 08 Jun 2005 11:58:54 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Eric Anderson References: <200506032012.j53KCC5k077879@repoman.freebsd.org> <42A6DA72.2070105@centtech.com> In-Reply-To: <42A6DA72.2070105@centtech.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-acpi@freebsd.org, Warner Losh Subject: Re: cvs commit: src/sys/dev/acpica acpi.c X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2005 19:01:38 -0000 Eric Anderson wrote: > Warner Losh wrote: > >> imp 2005-06-03 20:12:12 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/dev/acpica acpi.c Log: >> In newbus land, ivars can only be accessed for direct child, or when >> the driver has unholy private knowledge of its great-*cgrandchildren. >> The ACPI allocation routine lacked such knowledge when it tried to do >> a default allocation for all descendants, rather than just its >> immeidate children, so would access grandchild's ivar in an unsafe >> way. This could lead to a panic when devices were present which had >> no addresses setup by the BIOS, but which were later allocated in a >> lazy manner via pci_alloc_map. As such, only do the default >> allocation adjustments for immediate children. The manner that >> acpi_sysres_find accesses the resource list, used later in >> acpi_alloc_resource, is safe and proper so no additional test is >> needed there. >> This fixes a panic when probing an disabled ata controller on some >> newer intel blades. >> Reported by: dwhite >> Revision Changes Path >> 1.214 +1 -1 src/sys/dev/acpica/acpi.c > > > Warner - I owe you a beer! I believe this commit got my Dell D610 > laptop (and maybe the D600's?) to go into S3 mode, which prior to this > commit it would power off the machine instead of going into S3. Great. It should be MFCd also. -- Nate