From owner-freebsd-arch@FreeBSD.ORG  Tue Oct 31 22:20:42 2006
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
X-Original-To: arch@FreeBSD.org
Delivered-To: freebsd-arch@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5524A16A49E
	for <arch@FreeBSD.org>; Tue, 31 Oct 2006 22:20:42 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 09EDF43D4C
	for <arch@FreeBSD.org>; Tue, 31 Oct 2006 22:20:41 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id B87F946C5B;
	Tue, 31 Oct 2006 17:20:41 -0500 (EST)
Date: Tue, 31 Oct 2006 22:20:41 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Skip Ford <skip.ford@verizon.net>
In-Reply-To: <20061031212933.GA1001@lucy.pool-70-17-33-65.pskn.east.verizon.net>
Message-ID: <20061031221615.J96078@fledge.watson.org>
References: <20061031092122.D96078@fledge.watson.org>
	<20061031212933.GA1001@lucy.pool-70-17-33-65.pskn.east.verizon.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: arch@FreeBSD.org
Subject: Re: New in-kernel privilege API: priv(9)
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Oct 2006 22:20:42 -0000


On Tue, 31 Oct 2006, Skip Ford wrote:

> Robert Watson wrote:
>> Index: sys/contrib/altq/altq/altq_cdnr.c
>> ===================================================================
>> RCS file: /zoo/cvsup/FreeBSD-CVS/src/sys/contrib/altq/altq/altq_cdnr.c,v
>> retrieving revision 1.2
>> diff -u -r1.2 altq_cdnr.c
>> --- sys/contrib/altq/altq/altq_cdnr.c	12 Jun 2004 00:57:20 -0000	1.2
>> +++ sys/contrib/altq/altq/altq_cdnr.c	30 Oct 2006 17:07:54 -0000
>> @@ -1262,7 +1262,9 @@
>>  	case CDNR_GETSTATS:
>>  		break;
>>  	default:
>> -#if (__FreeBSD_version > 400000)
>> +#if (__FreeBSD_versoin > 700000)
>> +		if ((error = priv_check(p, PRIV_ALTQ_MANAGE)) != 0)
>> +#elsif (__FreeBSD_version > 400000)
>>  		if ((error = suser(p)) != 0)
>>  #else
>>  		if ((error = suser(p->p_ucred, &p->p_acflag)) != 0)
>
> s/versoin/version/
>
...
>
> Same thing.

Fixed in P4 and in my local CVS patch!

Thanks,

Robert N M Watson
Computer Laboratory
University of Cambridge