From owner-freebsd-current@FreeBSD.ORG Mon Dec 22 15:29:14 2008 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A4B0C1065670; Mon, 22 Dec 2008 15:29:14 +0000 (UTC) (envelope-from nork@FreeBSD.org) Received: from sakura.ninth-nine.com (unknown [IPv6:2001:2f0:104:80a0:230:48ff:fe41:2455]) by mx1.freebsd.org (Postfix) with ESMTP id 3C7868FC13; Mon, 22 Dec 2008 15:29:14 +0000 (UTC) (envelope-from nork@FreeBSD.org) Received: from nadesico.ninth-nine.com (nadesico.ninth-nine.com [219.127.74.122]) by sakura.ninth-nine.com (8.14.1/8.14.1/NinthNine) with SMTP id mBMFT5Qm016602; Tue, 23 Dec 2008 00:29:05 +0900 (JST) (envelope-from nork@FreeBSD.org) Date: Tue, 23 Dec 2008 00:29:01 +0900 From: Norikatsu Shigemura To: Maxim Sobolev Message-Id: <20081223002901.9b71e60d.nork@FreeBSD.org> In-Reply-To: <494F740E.3040502@FreeBSD.org> References: <20081221012752.cdc5cbfc.nork@FreeBSD.org> <20081221211949.GS1176@hoeg.nl> <20081222091203.GA28920@freebsd.org> <494F740E.3040502@FreeBSD.org> X-Mailer: Sylpheed 2.5.0 (GTK+ 2.12.11; i386-portbld-freebsd8.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.2 (sakura.ninth-nine.com [219.127.74.121]); Tue, 23 Dec 2008 00:29:06 +0900 (JST) Cc: Ed Schouten , Roman Divacky , FreeBSD Current , Norikatsu Shigemura Subject: Re: Change select(2) to kevent(2) on script(1)... X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Dec 2008 15:29:14 -0000 Hi sobomax! On Mon, 22 Dec 2008 03:03:42 -0800 Maxim Sobolev wrote: > Roman Divacky wrote: > > I believe other OSes should be able to do the porting effort when they > > want to use FreeBSD software. > > if kqueue-in-script makes any improvement go for it. > I really doubt there would be any. It's just 2 descriptors, and if > select(2) can't handle 2 descriptors efficiently them perhaps it is > broken and has to be fixed instead. I think that performance improvement is significant(I don't think performance improved by my patch). But my patch is the first implementation of kqueue/kevent support for TTY. In fact, I could find a bug. I hope to commit my patch. But by performance reason, my patch is not accepted, I have no problem. Hi ed! Thanks for your fix. I confirmed that my patch is good works.