From owner-freebsd-ports@FreeBSD.ORG Sat Jan 14 07:09:52 2006 Return-Path: X-Original-To: ports@freebsd.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C499116A41F for ; Sat, 14 Jan 2006 07:09:52 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mail2.fluidhosting.com [204.14.90.12]) by mx1.FreeBSD.org (Postfix) with SMTP id CB23643D55 for ; Sat, 14 Jan 2006 07:09:51 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 88358 invoked by uid 399); 14 Jan 2006 07:09:50 -0000 Received: from localhost (HELO ?192.168.1.101?) (dougb@dougbarton.us@127.0.0.1) by localhost with SMTP; 14 Jan 2006 07:09:50 -0000 Message-ID: <43C8A3BC.1070108@FreeBSD.org> Date: Fri, 13 Jan 2006 23:09:48 -0800 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 1.5 (X11/20060112) MIME-Version: 1.0 To: Ion-Mihai Tetcu References: <1137031540.61580@it.buh.tecnik93.com> <43C6EAE9.5070901@rogers.com> <20060113020125.5c1317a1@it.buh.tecnik93.com> In-Reply-To: <20060113020125.5c1317a1@it.buh.tecnik93.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: ports@freebsd.org, Mike Jakubik , FreeBSD gnats submit Subject: Re: [PATCH] security/courier-authlib-base: update rc.d script to REQUIRE mysql_client X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jan 2006 07:09:52 -0000 Ion-Mihai Tetcu wrote: > On Thu, 12 Jan 2006 18:48:57 -0500 > Mike Jakubik wrote: >> I think the real solution would be to generate the required services >> dynamically based on what the port is compiled with. This obviously >> means some more work, but i think a lot of port maintainers will have >> to go through this, to properly utilize RCng. Examples can be >> apparently taken from the misc/compat5 port. > > Or my mail/dspam-devel. You definitely have some cool stuff in there! I would like to mention one little nit, that I was actually reminded of myself recently. When you do default variable values, it's better to do it like this: dspam_enable=${dspam_enable-"NO"} rather than with the colon. That way if the user has done this in /etc/rc.conf: dspam_enable="" the default will still be no (since - replaces the value only if it's unset, whereas :- replaces if it is unset OR null). This isn't too meaningful for things like _enable where either result would have basically the same effect, but it is meaningful for things like _flags, where in your script, if the user did dspam_flags="" they would unexpectedly have nothing replaced with your default. hth, Doug -- This .signature sanitized for your protection